Skip to content

Commit a11870b

Browse files
malfetfacebook-github-bot
authored andcommitted
Revert D22118971: [android] gradle version update
Test Plan: revert-hammer Differential Revision: D22118971 (pytorch@262ad8e) Original commit changeset: 566e45e8f6f7 fbshipit-source-id: 74cfec0c978b724d84460a6d0c98f97b389811f7
1 parent b0324a9 commit a11870b

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

.circleci/docker/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ case "$image" in
139139
PROTOBUF=yes
140140
ANDROID=yes
141141
ANDROID_NDK_VERSION=r19c
142-
GRADLE_VERSION=6.5
142+
GRADLE_VERSION=4.10.3
143143
CMAKE_VERSION=3.7.0
144144
NINJA_VERSION=1.9.0
145145
;;

.circleci/scripts/build_android_gradle.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export ANDROID_HOME=/opt/android/sdk
66

77
# Must be in sync with GRADLE_VERSION in docker image for android
88
# https://github.com/pietern/pytorch-dockerfiles/blob/master/build.sh#L155
9-
export GRADLE_VERSION=6.5
9+
export GRADLE_VERSION=4.10.3
1010
export GRADLE_HOME=/opt/gradle/gradle-$GRADLE_VERSION
1111
export GRADLE_PATH=$GRADLE_HOME/bin/gradle
1212

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ allprojects {
2525
}
2626

2727
dependencies {
28-
classpath 'com.android.tools.build:gradle:4.2.0-alpha01'
28+
classpath 'com.android.tools.build:gradle:3.3.2'
2929
classpath "com.jfrog.bintray.gradle:gradle-bintray-plugin:${GRADLE_BINTRAY_PLUGIN_VERSION}"
3030
classpath "com.github.dcendents:android-maven-gradle-plugin:${ANDROID_MAVEN_GRADLE_PLUGIN_VERSION}"
3131
classpath "org.jfrog.buildinfo:build-info-extractor-gradle:4.9.8"

android/test_app/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ android {
6666
}
6767
resnet18 {
6868
dimension "model"
69-
applicationIdSuffix ".resnet18"
69+
applicationIdSuffix ".resneti18"
7070
buildConfigField("String", "MODULE_ASSET_NAME", "\"resnet18.pt\"")
7171
addManifestPlaceholders([APP_NAME: "RN18"])
7272
buildConfigField("String", "LOGCAT_TAG", "\"pytorch-resnet18\"")

scripts/build_pytorch_android.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ build_android
4141
# systemProp.https.proxyPort=8080
4242

4343
if [ "$CUSTOM_ABIS_LIST" = true ]; then
44-
$GRADLE_PATH -PABI_FILTERS=$ABIS_LIST -p $PYTORCH_ANDROID_DIR clean assembleRelease
44+
# Skipping clean task here as android gradle plugin 3.3.2 exteralNativeBuild has problems
45+
# with it when abiFilters are specified.
46+
$GRADLE_PATH -PABI_FILTERS=$ABIS_LIST -p $PYTORCH_ANDROID_DIR assembleRelease
4547
else
4648
$GRADLE_PATH -p $PYTORCH_ANDROID_DIR clean assembleRelease
4749
fi

0 commit comments

Comments
 (0)