Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse Geocoding no longer works starting with 0.14.7 #300

Closed
chrisl8 opened this issue Oct 3, 2024 · 6 comments
Closed

Reverse Geocoding no longer works starting with 0.14.7 #300

chrisl8 opened this issue Oct 3, 2024 · 6 comments

Comments

@chrisl8
Copy link
Contributor

chrisl8 commented Oct 3, 2024

I'm getting "RuntimeError" on every geocoding attempt now:

dawarich-sidekiq  | 2024-10-03T00:11:55.505Z pid=99 tid=i9z class=ReverseGeocodingJob jid=8b2afe62221cfe46b3f7242a elapsed=0.197 INFO: fail
dawarich-sidekiq  | 2024-10-03T00:11:55.508Z pid=99 tid=i9z WARN: {"context":"Job raised exception","job":{"retry":true,"queue":"reverse_geocoding","wrapped":"ReverseGeocodingJob","args":[{"job_class":"ReverseGeocodingJob","job_id":"22a4df36-0b42-49a6-9167-03140dd86276","provider_job_id":null,"queue_name":"reverse_geocoding","priority":null,"arguments":["Point",4785099],"executions":0,"exception_executions":{},"locale":"en","timezone":"America/Chicago","enqueued_at":"2024-10-03T00:11:35.711141708Z","scheduled_at":null}],"class":"ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper","jid":"8b2afe62221cfe46b3f7242a","created_at":1727914295.7112067,"enqueued_at":1727914315.3080666,"error_message":"","error_class":"RuntimeError","failed_at":1727914295.800561,"retry_count":0}}
dawarich-sidekiq  | 2024-10-03T00:11:55.508Z pid=99 tid=i9z WARN: RuntimeError:
dawarich-sidekiq  | 2024-10-03T00:11:55.511Z pid=99 tid=i9z WARN: app/services/reverse_geocoding/points/fetch_data.rb:15:in `call'
dawarich-sidekiq  | app/jobs/reverse_geocoding_job.rb:9:in `perform'

I believe it is caused by this:
6aaab42

Removing config/initializers/00_monkey_patching.rb and restarting my containers fixes the issue.

It is a shame, as I was looking forward to trying to integrate photon in my compose file if HTTPS wasn't required, but it doesn't appear to work.

@Freika
Copy link
Owner

Freika commented Oct 3, 2024

I guess it's not as easy as I thought :) Will disable it for now with the next release.

@chrisl8
Copy link
Contributor Author

chrisl8 commented Oct 3, 2024

Too bad there is not more error information given. It is impossible to tell from the small output what is going wrong.

It seems like maybe the patch is happening too late in the process and something has already run to set other values.

I also tried to fork the Geocoder repo, edit it and point Ruby at it, but that didn't work either, it just complains that the package hasn't been installed after installing it which is apparently a common issue with the Ruby bundler that has no solution.


Anyway, it doesn't really matter. It just causes some CPU load and maybe a few retries when I have Dawarich and Photon on different Tailscale hosts and the system has to encrypt data to/from itself. This only happens when importing big files. During normal day to day work it isn't noticeable.

I think I'm mostly just frustrated that I can't change one word of code in an open source project. 😂

@Freika
Copy link
Owner

Freika commented Oct 3, 2024

Fixed in 0.15.0

@Freika Freika closed this as completed Oct 3, 2024
@chrisl8
Copy link
Contributor Author

chrisl8 commented Oct 15, 2024

@Freika alexreisner/geocoder#1664

@Freika
Copy link
Owner

Freika commented Oct 15, 2024

@chrisl8 wow that's proactive! Thank you so much! I'll update the geocoder library in the next release 🔥🔥🔥

@chrisl8
Copy link
Contributor Author

chrisl8 commented Oct 16, 2024

@Freika It works! Thanks so much for pulling in the static library version!

FYI: I set PHOTON_API_HOST to photon:2322
The port on the end seems to be the "secret sauce" to make it use HTTP instead of HTTPS successfully.

It is nice to just hide the photon container inside my Dawarich setup now, and it feels like it is faster, although it probably isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants