Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory - MAC Address #1030

Open
10 of 14 tasks
Rene2mt opened this issue Dec 24, 2024 · 1 comment · May be fixed by #1057
Open
10 of 14 tasks

Inventory - MAC Address #1030

Rene2mt opened this issue Dec 24, 2024 · 1 comment · May be fixed by #1057

Comments

@Rene2mt
Copy link
Member

Rene2mt commented Dec 24, 2024

Constraint Task

Consistent with issue #813, this constraint focuses on ensuring MAC address information is provided when applicable via the "mac-address" prop for inventory item.

Intended Outcome

MAC address is an optional property, but SHOULD be present when the inventory item has a MAC address.

There may be more than one MAC addresses if the inventory item has multiple network interfaces.

Syntax Type

This is optional core OSCAL syntax.

Allowed Values

There are no relevant allowed values.

Metapath(s) to Content

//inventory-item/prop[@name='mac-address']

regex = “^([0-9A-Fa-f]{2}[:-]){5}([0-9A-Fa-f]{2})|([0-9a-fA-F]{4}\\.[0-9a-fA-F]{4}\\.[0-9a-fA-F]{4})$”;

Purpose of the OSCAL Content

No response

Dependencies

No response

Acceptance Criteria

  • All OSCAL adoption content affected by the change in this issue have been updated in accordance with the Documentation Standards.
    • Explanation is present and accurate
    • sample content is present and accurate
    • Metapath is present, accurate, and does not throw a syntax exception using oscal-cli metaschema metapath eval -e "expression".
  • All constraints associated with the review task have been created
  • The appropriate example OSCAL file is updated with content that demonstrates the FedRAMP-compliant OSCAL presentation.
  • The constraint conforms to the FedRAMP Constraint Style Guide.
    • All automated and manual review items that identify non-conformance are addressed; or technical leads (David Waltermire; AJ Stein) have approved the PR and “override” the style guide requirement.
  • Known good test content is created for unit testing.
  • Known bad test content is created for unit testing.
  • Unit testing is configured to run both known good and known bad test content examples.
  • Passing and failing unit tests, and corresponding test vectors in the form of known valid and invalid OSCAL test files, are created or updated for each constraint.
  • A Pull Request (PR) is submitted that fully addresses the goals section of the User Story in the issue.
  • This issue is referenced in the PR.

Other information

No response

@Rene2mt Rene2mt added the enhancement New feature or request label Dec 24, 2024
@Rene2mt Rene2mt moved this from 🆕 New to 🔖 Ready in FedRAMP Automation Dec 24, 2024
@Gabeblis Gabeblis self-assigned this Dec 31, 2024
@Gabeblis Gabeblis moved this from 🔖 Ready to 🏗 In progress in FedRAMP Automation Dec 31, 2024
@Gabeblis
Copy link
Contributor

@Rene2mt Since this constraint is using regex to enforce a format, should we consider making this an error instead of a warning? If the MAC address prop itself is optional, I think when it is used it must have the correct format.

@Gabeblis Gabeblis linked a pull request Dec 31, 2024 that will close this issue
7 tasks
@Gabeblis Gabeblis moved this from 🏗 In progress to 👀 In review in FedRAMP Automation Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

2 participants