-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify string matching code #707
Comments
Another argument for glob style matching is that we can avoid having to construct objects as we would for regexes - this is very useful in that we can just have a match function taking const char *, and directly pass in the values we get from StringPlug::getValue(). Otherwise we'd be left having to convert to a regex every single time we accessed a plug, which would be a lot, or having to introduce yet another plug type which stores regexes internally, or some other overly complex thing. In that case I don't think we really want a string matching object - just a function is sufficient, and allows callers to manage their own storage as appropriate. |
This is extracted from PathMatcher and will be used as the basis for unifying string matching across Gaffer as required by GafferHQ#707.
This is extracted from PathMatcher and will be used as the basis for unifying string matching across Gaffer as required by GafferHQ#707.
This is extracted from PathMatcher and will be used as the basis for unifying string matching across Gaffer as required by GafferHQ#707.
This is extracted from PathMatcher and will be used as the basis for unifying string matching across Gaffer as required by GafferHQ#707.
This is extracted from PathMatcher and will be used as the basis for unifying string matching across Gaffer as required by GafferHQ#707.
This has been deprecated for almost 3 years, and recent improvements in metadata matching should have rendered it totally unnecessary. This removes one of the main hurdles in completing GafferHQ#707. Breaking Change : - Removed `PlugValueWidget.registerCreator()`. Use metadata instead.
I think we're within shooting distance of having this done now. Here's the list of places where we still expose regexes publicly rather than use the syntax from
|
This has been deprecated for almost 3 years, and recent improvements in metadata matching should have rendered it totally unnecessary. This removes one of the main hurdles in completing GafferHQ#707. Breaking Change : - Removed `PlugValueWidget.registerCreator()`. Use metadata instead.
We're performing various different styles of string matching in Gaffer :
We should reimplement all such code to use a single Gaffer class intended for the purpose. The basis for this should be the glob matching implemented in PathFilter - although regexes are more powerful, they're also way more confusing for users, and we haven't had a use case for them yet, despite their availability.
The text was updated successfully, but these errors were encountered: