Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate Validation is bypassed for the web requests used. #85

Open
jwittner opened this issue Sep 19, 2017 · 4 comments
Open

Certificate Validation is bypassed for the web requests used. #85

jwittner opened this issue Sep 19, 2017 · 4 comments
Assignees

Comments

@jwittner
Copy link
Collaborator

jwittner commented Sep 19, 2017

Right now certificate validation is bypassed, which is a serious security concern.

Currently thinking we could add support for warning the user and letting them opt-in to the bypass action (with optional future white-listing). We could only allow bypass for certs matching some factors, e.g. date ranges.

@jwittner
Copy link
Collaborator Author

This issue goes away if I run mozroots.exe --import --sync, but this executable is only available in the MonoBleedingEdge directory of Unity.

The print out of mozroots.exe says it's been deprecated and that we should use cert-sync, which may work, but requires a certificate in PEM format to sync with. I haven't figured out what the right certificate is for that yet.

@jwittner
Copy link
Collaborator Author

Note for reproducing it's useful to clear your Trusted certs after running mozroots. I'm using this powershell command : .\certmgr.exe -list -c Trust |? { $_ -match "Unique Hash:\s+(\w+)" } |% { .\certmgr.exe -del -c Trust $Matches[1] }

@ForrestTrepte
Copy link
Collaborator

I'm taking a look to see if this can be solved by using UnityWebRequest.

@ForrestTrepte
Copy link
Collaborator

I couldn't quite figure out how to make this work via UnityWebRequest. I was successful in loading package information from the VSTS feed using UnityWebRequest without the need for bypassing certificate validation. But unfortunately, when it came time to download the package itself, I had an InvalidAuthenticationInfo error and was unable to download the package even when using .NET 4.6. I'm giving up, at least for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants