Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect PROXY_URL in script.js for multimodal-live-api #1567

Open
1 task done
heiko-hotz opened this issue Dec 20, 2024 · 1 comment
Open
1 task done

[Bug]: Incorrect PROXY_URL in script.js for multimodal-live-api #1567

heiko-hotz opened this issue Dec 20, 2024 · 1 comment
Assignees

Comments

@heiko-hotz
Copy link
Contributor

heiko-hotz commented Dec 20, 2024

File Name

gemini/multimodal-live-api/websocket-demo-app/frontend/script.js

What happened?

The proxy URL is incorrect. For local setup it probably should be

const PROXY_URL = "ws://localhost:8080";

The Cloud Run option describes how to do it there, but if a user only wants to do local setup they won't read that and expect it to work.

I'd recommend either setting a default proxy URL that works for local setup (preferred) or point the user in the README in the section for local setup to the code where they need to make a change.

Relevant log output

window.addEventListener("load", (event) => {
    console.log("Hello Gemini Realtime Demo!");

    setAvalibleCamerasOptions();
    setAvalibleMicrophoneOptions();
});


const PROXY_URL = "wss://[THE_URL_YOU_COPIED_WITHOUT_HTTP]";

Code of Conduct

  • I agree to follow this project's Code of Conduct
ZackAkil pushed a commit that referenced this issue Dec 20, 2024
# Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [X] Follow the [`CONTRIBUTING`
Guide](https://github.com/GoogleCloudPlatform/generative-ai/blob/main/CONTRIBUTING.md).
- [ ] You are listed as the author in your notebook or README file.
- [ ] Your account is listed in
[`CODEOWNERS`](https://github.com/GoogleCloudPlatform/generative-ai/blob/main/.github/CODEOWNERS)
for the file(s).
- [X] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- [ ] Ensure the tests and linter pass (Run `nox -s format` from the
repository root to format).
- [ ] Appropriate docs were updated (if necessary)

Fixes #1567
@holtskinner holtskinner reopened this Dec 20, 2024
@heiko-hotz
Copy link
Contributor Author

please note that #1569 only fixes #1568 . this is a separate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants