Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flickering while loading view #65

Open
pmuens opened this issue Nov 17, 2015 · 6 comments
Open

Remove flickering while loading view #65

pmuens opened this issue Nov 17, 2015 · 6 comments
Labels

Comments

@pmuens
Copy link
Member

pmuens commented Nov 17, 2015

The view "flickers" a little bit when it's loaded. This is caused by the layout.html file where two different areas are defined (one for the signed in user and one for the signed out user).

https://github.com/GravityProject/gravity/blob/master/client/views/layout.html

This needs to be refactored to just one section where the view is yielded.

@pmuens pmuens added the bug label Nov 17, 2015
@pmuens pmuens self-assigned this Nov 17, 2015
@zaverichintan
Copy link
Member

Hey, is it s bug in meteor? I have been facing this in mobile browser alot.

@pmuens
Copy link
Member Author

pmuens commented Mar 24, 2016

No it's an implementation issue (because the check if the user can see it is done after the view is rendered).

@zaverichintan
Copy link
Member

oh. so we can check it with controller or router, I mean we can check it in JS part and then render the corresponding html (view) part , sounds good ?

@pmuens
Copy link
Member Author

pmuens commented Mar 24, 2016

I think we need just one section where the view is rendered for the layout. That should be sufficient.

https://github.com/GravityProject/gravity/blob/master/client/views/layout.html

@zaverichintan
Copy link
Member

so should we have navigation template in if else block ?

@pmuens
Copy link
Member Author

pmuens commented May 11, 2016

Could you provide an example please?

@pmuens pmuens removed their assignment Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants