fix test suite

Author: HDT3213

.github/workflows/main.yml

@@ -9,20 +9,20 @@ on:
   pull_request:
     branches: [ "master" ]
   workflow_dispatch:
-    
+
 
 jobs:
 
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    
-    - uses: actions/setup-go@v3
-      with:
-        go-version: '1.18'
-    - run: go test -v -coverprofile=profile.cov ./...
+      - uses: actions/checkout@v3
+
+      - uses: actions/setup-go@v3
+        with:
+          go-version: '1.18'
+      - run: go test -v -coverpkg=./core,./ -coverprofile=profile.cov ./...
 
-    - uses: shogo82148/actions-goveralls@v1
-      with:
-        path-to-profile: profile.cov
+      - uses: shogo82148/actions-goveralls@v1
+        with:
+          path-to-profile: profile.cov

cases/listpack.json

@@ -1,5 +1,5 @@
 [
 {"db":0,"key":"l","size":124,"type":"list","encoding":"quicklist2","values":["1","20000","aaaa","4","16380","-16380","1048576","268435456","8589934592"]},
-{"db":0,"key":"z","size":1308,"type":"zset","encoding":"listpack","entries":[{"member":"11","score":-8589934592},{"member":"9","score":-268435456},{"member":"7","score":-1048576},{"member":"5","score":-16380},{"member":"12","score":-2000},{"member":"3","score":0},{"member":"1","score":1},{"member":"2","score":2000},{"member":"4","score":16380},{"member":"6","score":1048576},{"member":"8","score":268435456},{"member":"10","score":8589934592}]},
+{"db":0,"key":"z","size":1292,"type":"zset","encoding":"listpack","entries":[{"member":"11","score":-8589934592},{"member":"9","score":-268435456},{"member":"7","score":-1048576},{"member":"5","score":-16380},{"member":"12","score":-2000},{"member":"3","score":0},{"member":"1","score":1},{"member":"2","score":2000},{"member":"4","score":16380},{"member":"6","score":1048576},{"member":"8","score":268435456},{"member":"10","score":8589934592}]},
 {"db":0,"key":"h","size":620,"type":"hash","encoding":"listpack","hash":{"1":"1","10":"8589934592","11":"8589934592","2":"2000","3":"aaaaaaaaaaaaaaaa","4":"16380","5":"-16380","6":"1048576","7":"-1048576","8":"268435456","9":"-268435456"}}
 ]

cases/rdb_version_8_with_64b_length_and_scores.json

@@ -0,0 +1,66 @@
+package core
+
+import (
+	"github.com/hdt3213/rdb/model"
+	"os"
+	"path/filepath"
+	"testing"
+)
+
+func TestWithSpecialObject(t *testing.T) {
+	rdbFilename := filepath.Join("../cases", "memory.rdb")
+	rdbFile, err := os.Open(rdbFilename)
+	if err != nil {
+		t.Errorf("open rdb %s failed, %v", rdbFilename, err)
+		return
+	}
+	defer func() {
+		_ = rdbFile.Close()
+	}()
+	expectAux := map[string]string{
+		"redis-ver":    "6.0.6",
+		"redis-bits":   "64",
+		"ctime":        "1644136130",
+		"used-mem":     "1167584",
+		"aof-preamble": "0",
+	}
+	expectKeyCount := map[int]uint64{
+		0: 7,
+	}
+	expectTTLCount := map[int]uint64{
+		0: 1,
+	}
+	var auxCount, dbSizeCount int
+	dec := NewDecoder(rdbFile).WithSpecialOpCode()
+	err = dec.Parse(func(object model.RedisObject) bool {
+		switch o := object.(type) {
+		case *model.AuxObject:
+			if o.GetType() != model.AuxType {
+				t.Error("aux obj with wrong type")
+			}
+			expectValue := expectAux[o.Key]
+			if o.Value != expectValue {
+				t.Errorf("aux %s has wrong value", o.GetKey())
+			}
+			auxCount++
+		case *model.DBSizeObject:
+			dbSizeCount++
+			if o.KeyCount != expectKeyCount[o.DB] {
+				t.Errorf("db %d has wrong key count", o.DB)
+			}
+			if o.TTLCount != expectTTLCount[o.DB] {
+				t.Errorf("db %d has wrong ttl count", o.DB)
+			}
+		}
+		return true
+	})
+	if err != nil {
+		t.Error(err)
+	}
+	if auxCount != len(expectAux) {
+		t.Error("wrong aux object count")
+	}
+	if dbSizeCount != 1 {
+		t.Error("wrong db size object count")
+	}
+}

cases/regular_sorted_set.json

@@ -3,6 +3,8 @@ package helper
 import (
 	"github.com/hdt3213/rdb/model"
 	"math/rand"
+	"os"
+	"path/filepath"
 	"sort"
 	"strconv"
 	"testing"
@@ -47,3 +49,91 @@ func TestRedisHeap_Append(t *testing.T) {
 		}
 	}
 }
+
+func TestFindLargestKeys(t *testing.T) {
+	err := os.MkdirAll("tmp", os.ModePerm)
+	if err != nil {
+		return
+	}
+	defer func() {
+		err := os.RemoveAll("tmp")
+		if err != nil {
+			t.Logf("remove tmp directory failed: %v", err)
+		}
+	}()
+	srcRdb := filepath.Join("../cases", "memory.rdb")
+	expectFile := filepath.Join("../cases", "largest.csv")
+	outputFilePath := filepath.Join("tmp", "largest.csv")
+	output, err := os.Create(outputFilePath)
+	if err != nil {
+		t.Errorf("create output file failed: %v", err)
+		return
+	}
+	err = FindBiggestKeys(srcRdb, 5, output)
+	if err != nil {
+		t.Errorf("FindLargestKeys failed: %v", err)
+	}
+	err = output.Close()
+	if err != nil {
+		t.Errorf("error occurs during close output %s, err: %v", srcRdb, err)
+		return
+	}
+	equals, err := compareFileByLine(t, outputFilePath, expectFile)
+	if err != nil {
+		t.Errorf("error occurs during compare %s, err: %v", srcRdb, err)
+		return
+	}
+	if !equals {
+		t.Errorf("result is not equal of %s", srcRdb)
+		return
+	}
+
+	err = FindBiggestKeys("", 5, os.Stdout)
+	if err == nil || err.Error() != "src file path is required" {
+		t.Error("failed when empty output")
+	}
+	err = FindBiggestKeys("cases/memory.rdb", 0, os.Stdout)
+	if err == nil || err.Error() != "n must greater than 0" {
+		t.Error("failed when empty output")
+	}
+}
+
+func TestFindBiggestKeyWithRegex(t *testing.T) {
+	err := os.MkdirAll("tmp", os.ModePerm)
+	if err != nil {
+		return
+	}
+	defer func() {
+		err := os.RemoveAll("tmp")
+		if err != nil {
+			t.Logf("remove tmp directory failed: %v", err)
+		}
+	}()
+	srcRdb := filepath.Join("../cases", "memory.rdb")
+	actualFile := filepath.Join("../cases", "memory_regex.biggest.csv")
+	expectFile := filepath.Join("../cases", "memory_regex.biggest.csv")
+	output, err := os.Create(actualFile)
+	if err != nil {
+		t.Errorf("create output file failed: %v", err)
+		return
+	}
+	err = FindBiggestKeys(srcRdb, 2, output, WithRegexOption("^l.*"))
+	if err != nil {
+		t.Errorf("error occurs during parse, err: %v", err)
+		return
+	}
+	equals, err := compareFileByLine(t, actualFile, expectFile)
+	if err != nil {
+		t.Errorf("error occurs during compare err: %v", err)
+		return
+	}
+	if !equals {
+		t.Errorf("result is not equal")
+		return
+	}
+
+	err = FindBiggestKeys(srcRdb, 2, output, WithRegexOption(`(i)\1`))
+	if err == nil {
+		t.Error("expect error")
+	}
+}