Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distutils #164

Open
fabaff opened this issue Mar 18, 2024 · 8 comments · May be fixed by #166
Open

Remove distutils #164

fabaff opened this issue Mar 18, 2024 · 8 comments · May be fixed by #166

Comments

@fabaff
Copy link

fabaff commented Mar 18, 2024

distutils is deprecated and slated for removal in Python 3.12

https://peps.python.org/pep-0632//#migration-advice

@ojii
Copy link
Contributor

ojii commented Mar 18, 2024

this project doesn't use distutils from what I can see. what exactly are you suggesting should change?

@fabaff
Copy link
Author

fabaff commented Mar 19, 2024

this project doesn't use distutils from what I can see

from distutils.version import StrictVersion

@ojii
Copy link
Contributor

ojii commented Mar 19, 2024

ah, i was only looking in packaging related code.

@fabaff
Copy link
Author

fabaff commented Apr 4, 2024

arsenic is a dependency of wapiti and with distutils it would not be possible to wapiti with Python 3.12.

@fabaff fabaff linked a pull request Apr 4, 2024 that will close this issue
@catap
Copy link

catap commented Dec 18, 2024

Python 3.12 is coming for everyone and this needs to be fixed.

@ojii, do you plan to make a new release with this fix?

I'm asking because @devl00p had forked arsenic for wapiti... and the future of his fork is unclear to me, when and if the new version of arseinc will be released.

@ojii
Copy link
Contributor

ojii commented Dec 23, 2024

Python 3.12 is coming for everyone and this needs to be fixed.

I'm on 3.12/3.13 these days and arsenic still works for me.

arsenic does what I need it to do, so it doesn't receive a lot of maintenance, given how much of a pain it is to test any changes to this library.

@dimaqq
Copy link
Contributor

dimaqq commented Dec 23, 2024

PRs are most welcome.

here’s what I’d do (didn’t test, ymmv):

[tool.poetry.dependencies]
packaging = "^23.0"

And then

from packaging.version import Version


# Old code
if StrictVersion(current_version) < StrictVersion('1.0.0'):
    # perform some action

# Updated code
if Version(current_version) < Version('1.0.0'):
    # perform some action

@ojii
Copy link
Contributor

ojii commented Dec 23, 2024

PRs are most welcome.

there is a PR already, that's not the issue #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants