Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch incorrectly not detected #72

Open
gwillem opened this issue Mar 15, 2018 · 1 comment
Open

Patch incorrectly not detected #72

gwillem opened this issue Mar 15, 2018 · 1 comment
Labels

Comments

@gwillem
Copy link
Contributor

gwillem commented Mar 15, 2018

Line from applied_patches.list:

2015-12-21 17:50:12 UTC | SUPEE-6285 | CE_1.9.1.1 | v2 | 7226d88b1eeb07a5fbc4e62be189a5219457cc14 | Mon Jun 22 16:32:26 2015 +0300 | 202596e441..7226d88b1e

But reported by list-patches:

| SUPEE-6285      | required | No      |
@gwillem gwillem added the bug label Mar 15, 2018
@frosit
Copy link
Contributor

frosit commented Jun 11, 2018

I think this isn't a problem with hypernode-magerun but a problem caused by outdated patch data. tools.hypernode.com aggregates it's patch info from the patches spreadsheet which isn't updated regularly. Both the spreadsheet and https://tools.hypernode.com/patches/community/1.9.1.1 don't show there is a v2 patch and this might be why v1 is not detected.

This is one of the main reasons why I build magepatch as it aggregates it's data from the community driven magento-patches repository. Unfortunately this patch wasn't there either so I just added it and updated my patch index.

I can't update the spreadsheet but we can change the command to check if a newer version of a patch is installed and show a status like "newer version installed". Otherwise the problem should be fixed at the spreadsheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants