Fix test src dir and detekt (airbnb#392)

airbnb#373 broke tests by including the wrong source dir.
Detekt was also not run and was failing in several places.

@BenSchwab can we ensure that Detekt runs on CI.
cc @elihart @marukami

Author: gpeal

buildSrc/build.gradle.kts

@@ -1,5 +1,3 @@
-import java.util.Properties
-
 repositories {
     google()
     maven(url = "https://plugins.gradle.org/m2/")

buildSrc/settings.gradle.kts

@@ -59,13 +59,12 @@ class AndroidMetaModulePlugin : Plugin<Project> {
                                 setSrcDirs(srcDirs + file("src/main/kotlin"))
                             }
                             getByName("test").java.apply {
-                                setSrcDirs(srcDirs + file("src/main/kotlin"))
+                                setSrcDirs(srcDirs + file("src/test/kotlin"))
                             }
                         }
                     }
                 }
             }
         }
     }
-
 }

buildSrc/src/main/java/com/airbnb/mvrx/AndroidMetaModulePlugin.kt

@@ -22,10 +22,10 @@ open class JacocoReportTask : JacocoReport() {
         )
         val buildDir = project.buildDir
 
-        val debugTree = project.fileTree("${buildDir}/intermediates/classes/debug") {
+        val debugTree = project.fileTree(buildDir.toString() + "/intermediates/classes/debug") {
             exclude(excludes)
         }
-        val kotlinDebugTree = project.fileTree("${buildDir}/tmp/kotlin-classes/debug") {
+        val kotlinDebugTree = project.fileTree(buildDir.toString() + "/tmp/kotlin-classes/debug") {
             exclude(excludes)
         }
 
@@ -37,4 +37,3 @@ open class JacocoReportTask : JacocoReport() {
         executionData.from("$buildDir/jacoco/testDebugUnitTest.exec")
     }
 }
-

buildSrc/src/main/java/com/airbnb/mvrx/JacocoReportTask.kt

@@ -38,7 +38,7 @@ class MainActivity : AppCompatActivity() {
         }
     }
 
-    override fun onOptionsItemSelected(item: MenuItem?) = when (item?.itemId ?: 0) {
+    override fun onOptionsItemSelected(item: MenuItem) = when (item.itemId ?: 0) {
         android.R.id.home -> {
             if (navController.currentDestination?.isDrawerDestination() == true) {
                 drawerLayout.openDrawer(GravityCompat.START)