Upgrade Kotlin to 1.3.50, AGP to 3.5.0, and Gradle to 5.6 (airbnb#275)

This seems to fix airbnb#256.
However, it didn't crash while I was developing it, started crashing somehow and even after upgrading, it crashed until I moved the function and moved it back and now it isn't crashing. I tried various combinations of running clean and rm -rf */build/**.

Upgrading these things should be good anyway and hopefully it also fixes this.

I also:

Upgraded a few other dependencies such as AGP but the that broke robolectric so I upgraded that and removed shadows-support-v4 since jetifier now breaks on it and we don't need it anymore.
Fixed a new lint error that was caught after upgrading (ArrayMap sdk check)
Fixed detekt errors since I have them as a pre-push hook.

Author: gpeal

build.gradle

@@ -1,9 +1,9 @@
 buildscript {
-    ext.kotlinVersion = '1.3.31'
+    ext.kotlinVersion = '1.3.50'
     ext.appCompatVersion = '1.0.2'
     ext.recyclerViewVersion = '1.0.0'
     ext.lifecycleVersion = '2.0.0'
-    ext.robolectricVersion = '4.0.2'
+    ext.robolectricVersion = '4.3'
     ext.epoxyVersion = '3.2.0'
     ext.moshiVersion = '1.6.0'
     ext.koinVersion = '2.0.1'
@@ -18,7 +18,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.2.1'
+        classpath 'com.android.tools.build:gradle:3.5.0'
         classpath "org.jetbrains.kotlin:kotlin-android-extensions:$kotlinVersion"
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
         classpath 'net.sf.proguard:proguard-gradle:6.1.1'

gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.3-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.6-all.zip

mvrx/build.gradle

@@ -62,7 +62,6 @@ dependencies {
     testImplementation "org.mockito:mockito-core:2.25.1"
     testImplementation 'junit:junit:4.12'
     testImplementation "org.robolectric:robolectric:$robolectricVersion"
-    testImplementation "org.robolectric:shadows-supportv4:$robolectricVersion"
 }
 
 // Ensure custom source sets are included:

mvrx/src/main/kotlin/com/airbnb/mvrx/BaseMvRxViewModel.kt

@@ -215,9 +215,9 @@ abstract class BaseMvRxViewModel<S : MvRxState>(
             success.metadata = successMetaData?.invoke(value)
             success
         }
-            .onErrorReturn {
-                if (debugMode) Log.e(tag, "Observable encountered error", it)
-                Fail(it)
+            .onErrorReturn { e ->
+                if (debugMode) Log.e(tag, "Observable encountered error", e)
+                Fail(e)
             }
             .subscribe { asyncData -> setState { stateReducer(asyncData) } }
             .disposeOnClear()

mvrx/src/main/kotlin/com/airbnb/mvrx/MvRxExtensions.kt

@@ -39,16 +39,16 @@ inline fun <T, reified VM : BaseMvRxViewModel<S>, reified S : MvRxState> T.paren
     crossinline keyFactory: () -> String = { viewModelClass.java.name }
 ): Lazy<VM> where T : Fragment, T : MvRxView = lifecycleAwareLazy(this) {
     requireNotNull(parentFragment) { "There is no parent fragment for ${this::class.java.simpleName}!" }
-    val notFoundMessage by lazy { "There is no ViewModel of type ${VM::class.java.simpleName} for this Fragment!" }
-    val factory = MvRxFactory { error(notFoundMessage) }
+    val notFoundMessage = { "There is no ViewModel of type ${VM::class.java.simpleName} for this Fragment!" }
+    val factory = MvRxFactory { error(notFoundMessage()) }
     var fragment: Fragment? = parentFragment
     val key = keyFactory()
     while (fragment != null) {
         try {
             return@lifecycleAwareLazy ViewModelProviders.of(fragment, factory).get(key, viewModelClass.java)
                 .apply { subscribe(this@parentFragmentViewModel, subscriber = { postInvalidate() }) }
         } catch (e: java.lang.IllegalStateException) {
-            if (e.message == notFoundMessage) {
+            if (e.message == notFoundMessage()) {
                 fragment = fragment.parentFragment
             } else {
                 throw e

mvrx/src/main/kotlin/com/airbnb/mvrx/MvRxMutabilityHelper.kt

@@ -1,5 +1,6 @@
 package com.airbnb.mvrx
 
+import android.os.Build
 import android.util.SparseArray
 import androidx.collection.ArrayMap
 import androidx.collection.LongSparseArray
@@ -39,9 +40,9 @@ internal fun KClass<*>.assertImmutability() {
             prop.isSubtype(SparseArray::class) -> "You cannot use SparseArray for ${prop.name}.\n$IMMUTABLE_LIST_MESSAGE"
             prop.isSubtype(LongSparseArray::class) -> "You cannot use LongSparseArray for ${prop.name}.\n$IMMUTABLE_LIST_MESSAGE"
             prop.isSubtype(SparseArrayCompat::class) -> "You cannot use SparseArrayCompat for ${prop.name}.\n$IMMUTABLE_LIST_MESSAGE"
-            prop.isSubtype(ArrayMap::class, android.util.ArrayMap::class) -> {
-                "You cannot use ArrayMap for ${prop.name}.\n$IMMUTABLE_MAP_MESSAGE"
-            }
+            prop.isSubtype(ArrayMap::class) -> "You cannot use ArrayMap for ${prop.name}.\n$IMMUTABLE_MAP_MESSAGE"
+            Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT &&
+                prop.isSubtype(android.util.ArrayMap::class) -> "You cannot use ArrayMap for ${prop.name}.\n$IMMUTABLE_MAP_MESSAGE"
             prop.isSubtype(HashMap::class) -> "You cannot use HashMap for ${prop.name}.\n$IMMUTABLE_MAP_MESSAGE"
             prop.isSubtype(Function::class, KCallable::class) -> {
                 "You cannot use functions inside MvRx state. Only pure data should be represented: ${prop.name}"

mvrx/src/main/kotlin/com/airbnb/mvrx/MvRxViewId.kt

@@ -1,7 +1,7 @@
 package com.airbnb.mvrx
 
 import android.os.Bundle
-import java.util.*
+import java.util.UUID
 import kotlin.properties.ReadOnlyProperty
 import kotlin.reflect.KProperty