Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion about crop size #27

Open
rightchose opened this issue Sep 2, 2021 · 5 comments
Open

Confusion about crop size #27

rightchose opened this issue Sep 2, 2021 · 5 comments

Comments

@rightchose
Copy link

0000000000

@rightchose
Copy link
Author

The image size is 1216x352? So follow your setting, the image feed in the model with size 1216 x352, but the top of the image is valid. The image I download from kitti depth completion rank.

@rightchose
Copy link
Author

So I wonder why not use 1216x256?

@rightchose
Copy link
Author

rightchose commented Sep 2, 2021

In my understanding, in main.py the args.val_h and args.val_w mean the size of area we crop from the image using bottom crop, and args.he and args.w is the size crop from the area.

@JUGGHM
Copy link
Owner

JUGGHM commented Sep 2, 2021

Hi! There are actually two settings. Ours follows the one of Ma et al.(Sparse2Dense) to feed the full sized images into the models. And the other one is cropping the images on the top into 1216x256 ones (e.g. GuideNet). Under this scheme, the top of the images are manually fulfilled when generating results on validation/test sets. Both of them are feasible while there might be some minor difference in performance.

@rightchose
Copy link
Author

Oh! Thanks a lot. So comparing your model with others on the kitti website, your result may be different on the top of image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants