Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal reliance on packages for npm dist #360

Closed
JeromeFitz opened this issue Jan 23, 2022 · 1 comment
Closed

internal reliance on packages for npm dist #360

JeromeFitz opened this issue Jan 23, 2022 · 1 comment

Comments

@JeromeFitz
Copy link
Owner

We have a condition where the following packages:

  • @jeromefitz/git-cz
  • @jeromefitz/semantic

Rely on package.json:

      "@jeromefitz/conventional-gitmoji": "*",

Which causes a stagger build process with npm.

Please determine if we can instead:

  • include the monorepo version of @jeromefitz/conventional-gitmoji not as an external dependency through tsup
  • or stagger the build process w/ turbo

Preference would be to remove the need to externally depend on npm
@JeromeFitz
Copy link
Owner Author

Too much yarn link 🤮

Fixed with latest builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeromeFitz