-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pnpm: dependabot strategy 🤖 #705
Comments
Or... migrate to Renovate. 😆 |
Closes Issue: #705 yup booleans are strings, going to put my head in the oven dependabot is not even going to pick this up anyway and we are going to have to move to renovate 😆 ![alt text](https://pbs.twimg.com/media/EZ5LLMgX0AAeUMm.jpg)
Straight up, this was not worth it. I think I have to move to Renovate at this rate because this hack is not good, haha. Instead of the aforementioned it does a few checks:
This creates (ejects) install from init, and adds a pnpm step if either of the above are tru (AND THOSE ARE STRINGS!), and then you better believe if you are not pinned all the way through your repo, it is going to do more to that lock file haha I am looking at you storybook So yea Unless you PIN everything, this is a colossal waste of time and adds confusion. Oh well. |
As an update we moved to Renovate. It was super simple and has a few added bonuses that I really like. PR is here: #710 |
🤖 Dependabot is not set up for
pnpm
yet. With no real plans to add this as a feature (understandably):https://github.com/dependabot/dependabot-core/issues/1736
I know they have to consider a lot more than updating a
pnpm-lock.yaml
, but we probably do not.Suggestion:
Can we handle this update as a CI automation to Dependabot's PRs to:
pnpm install
without the frozen lockfile settingpnpm-lock.yaml
fileBonus:
🤔 Can dependabot PRs be set to Draft Mode first, then this Action final step after pushing would be to Ready for Review the PR / Branch it updates
github.actor
isdependabot[bot]
⬆️ (deps) Bump
⬆️ (deps-dev) Bump
:arrow-up: (deps) Bump
:arrow-up: (deps-dev) Bump
📦 Dependencies
pull_request
Order of Operations may be:
pull_request
first check againstgithub.actor
&&github.event.head_commit.message
, if meets above requirements📦 pnpm
:package: pnpm
That would then set the PR back in a state to be checked against the existing GitHub Action
The text was updated successfully, but these errors were encountered: