Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshotting and effect handling for external entities are not handled correctly #29

Open
Jofairden opened this issue Jan 23, 2019 · 1 comment
Labels
complex A complex issue/solution enhancement

Comments

@Jofairden
Copy link
Owner

The current snapshotting for modifiers is mediocre and buggy at best.
A solution must be created for this problem

Scope:

  • Projectiles
  • NPCs
  • Projectiles shot by friendlies (minions)

Proposal

Proposed design: a snapshot of current active modifiers must be given to a particular entity (projectile, npc etc.) which can then be used in the appropriate hooks for effects. This will likely turn into boilerplate like ModifierItem.cs

@Jofairden Jofairden added enhancement complex A complex issue/solution labels Jan 23, 2019
@Jofairden Jofairden pinned this issue Jan 23, 2019
@Jofairden Jofairden added this to the 0.11-release milestone Jan 23, 2019
@Jofairden
Copy link
Owner Author

Jofairden commented May 12, 2019

TBD: Refactor ModifierEffect to ModifierPlayerEffect, add ModifierProjectileEffect and ModifierNpcEffect as new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complex A complex issue/solution enhancement
Projects
None yet
Development

No branches or pull requests

1 participant