Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32 #11

Open
robkwhitehouse opened this issue Nov 21, 2022 · 4 comments
Open

ESP32 #11

robkwhitehouse opened this issue Nov 21, 2022 · 4 comments

Comments

@robkwhitehouse
Copy link

Hi John-Lluch,
This looks exactly what I need and I will give it a try. I have tried one or two other Encoder libraries and they have given problems. I am using an ESP32 running the Arduino core. I will let you know how it goes but if you are aware of any potential problems I'd be grateful if you could let me know in advance.

Many thanks for all your work.

@John-Lluch
Copy link
Owner

Hi Rob, thanks for your feedback. Unfortunately, I'm almost 100% sure it won't work on a ESP32. The library uses low level stuff related to the 8 bit AVR architecture only. However, I encourage you to update or submit a pull request to make it compatible with the ESP32. I'll be very happy to incorporate it in the library including a mention to your contribution.

@robkwhitehouse
Copy link
Author

robkwhitehouse commented Nov 22, 2022 via email

@hazymat
Copy link

hazymat commented Jan 22, 2023

Any update on this?

@robkwhitehouse
Copy link
Author

Hi @hazymat - I had a look at this and actually coded up an ESP32 version - it wasn't a lot of work. BUT I have never got around testing my ESP32 version. I have now removed the rotary encoder from my project and so I now do not need this library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants