-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Euclidean should support local_metric
in DefaultOrthonormalBasis
#742
Comments
sounds reasonable – especially since for Euclidean this is very easy (you even could consider just using DiffEq per se then). Do you feel you could do an PR for this as well (or in your PR you plan to do)? If you are stuck somewhere we can help for sure (also with getting started with PRs and such). |
Yes, support for |
Okay I'll leave this to you |
Currently,
local_metric
only works for manifolds of typeEuclidean
when using anInducedBasis
. For consistency I think it might be nice to have this return the same thing for theDefaultOrthonormalBasis
, which seems to be used by most internal methods by default, e.g.solve_exp_ode
.The text was updated successfully, but these errors were encountered: