Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modpacks that have / in their names become inaccessible #500

Open
tempodat opened this issue Jul 2, 2023 · 1 comment
Open

Modpacks that have / in their names become inaccessible #500

tempodat opened this issue Jul 2, 2023 · 1 comment
Labels
Area: Backend Related to the Python code that runs inside gunicorn Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Low Scope: Medium Moderately complex changes requiring non-trivial time and effort to develop and review Type: Bug

Comments

@tempodat
Copy link

tempodat commented Jul 2, 2023

Description (What went wrong?):
I created a Modpack for KSP2 called "New/Updated Parts Mods". When I tried saving changes after editing it it showed me the 404 screen that shows this modpack doesn't exist. I can't edit or even rename or delete it now, when I try I get a 404.

Reproduction Steps (What did you do?):
Create a modpack that has a / character in its name. Try to edit or view it afterwards.
There might be more characters that break it.

Expected Behavior (What do you think should have happened instead?):
The normal creation of a modpack, along with it being possible to access it.

Environment (OS/Browser/Plugins/etc):
Windows 10, Firefox.

Extra Information (Screenshots/Error Messages/Javascript Console Output):
I think this fails because the / is messing with the URL, so substituting / for %2F or an underscore or something when constructing URLs should fix this.
Also there might be other characters that cause this, not just "/".

My inaccessible modpack is linked here, for reference.
https://spacedock.info/pack/489/New/Updated%20Parts%20Mods

@HebaruSan HebaruSan added Type: Bug Area: Backend Related to the Python code that runs inside gunicorn Priority: Low Area: Frontend Related to HTML, JS, CSS, or other browser things Scope: Medium Moderately complex changes requiring non-trivial time and effort to develop and review labels Jul 10, 2023
@HebaruSan
Copy link
Contributor

Hi @tempodat, thanks for the report. The name isn't used for anything, so as a workaround you can just change it to something else in the URL. This works:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Related to the Python code that runs inside gunicorn Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Low Scope: Medium Moderately complex changes requiring non-trivial time and effort to develop and review Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants