Adds muzzle flashes for guns depending on the ammo (ParadiseSS13#13322)

* Muzzle flashes added for guns

* Use an muzzle flash effect now.

* Unused var

* sillenced guns have a lower alpha muzzleflash effect

Author: farie82

code/__DEFINES/muzzle_flash.dm

@@ -0,0 +1,7 @@
+#define MUZZLE_FLASH_STRENGTH_WEAK 1
+#define MUZZLE_FLASH_STRENGTH_NORMAL 2
+#define MUZZLE_FLASH_STRENGTH_STRONG 3
+
+#define MUZZLE_FLASH_RANGE_WEAK 1
+#define MUZZLE_FLASH_RANGE_NORMAL 2
+#define MUZZLE_FLASH_RANGE_STRONG 3

code/game/gamemodes/changeling/powers/mutations.dm

@@ -221,6 +221,7 @@
 	projectile_type = /obj/item/projectile/tentacle
 	caliber = "tentacle"
 	icon_state = "tentacle_end"
+	muzzle_flash_effect = null
 	var/obj/item/gun/magic/tentacle/gun //the item that shot it
 
 /obj/item/ammo_casing/magic/tentacle/New(obj/item/gun/magic/tentacle/tentacle_gun)

code/game/objects/effects/temporary_visuals/muzzle_flashes.dm

@@ -0,0 +1,19 @@
+/obj/effect/temp_visual/target_angled/muzzle_flash
+	icon = 'icons/effects/projectile.dmi'
+	icon_state = "firing_effect"
+	duration = 0.2
+
+/obj/effect/temp_visual/target_angled/muzzle_flash/Initialize(mapload, atom/target, duration_override = null)
+	if(duration_override)
+		duration = duration_override
+	. = ..()
+	if(get_dir(src, target) & NORTH)
+		layer = BELOW_MOB_LAYER
+
+
+/obj/effect/temp_visual/target_angled/muzzle_flash/energy
+	icon_state = "firing_effect_energy"
+
+/obj/effect/temp_visual/target_angled/muzzle_flash/magic
+	icon = 'icons/effects/effects.dmi'
+	icon_state = "shieldsparkles"

code/game/objects/effects/temporary_visuals/temporary_visual.dm

@@ -35,3 +35,13 @@
 	if(set_dir)
 		setDir(set_dir)
 	. = ..()
+
+/obj/effect/temp_visual/target_angled
+	randomdir = FALSE
+
+/obj/effect/temp_visual/target_angled/Initialize(mapload, atom/target)
+	. = ..()
+	if(target)
+		var/matrix/M = new
+		M.Turn(get_angle(src, target))
+		transform = M

code/game/objects/items/weapons/chrono_eraser.dm

@@ -141,6 +141,8 @@
 /obj/item/ammo_casing/energy/chrono_beam
 	name = "eradication beam"
 	projectile_type = /obj/item/projectile/energy/chrono_beam
+	muzzle_flash_effect = /obj/effect/temp_visual/target_angled/muzzle_flash/energy
+	muzzle_flash_color = null
 	icon_state = "chronobolt"
 	e_cost = 0
 

code/modules/mining/lavaland/loot/tendril_loot.dm

@@ -358,6 +358,7 @@
 	projectile_type = /obj/item/projectile/hook
 	caliber = "hook"
 	icon_state = "hook"
+	muzzle_flash_effect = null
 
 /obj/item/projectile/hook
 	name = "hook"

code/modules/projectiles/ammunition.dm

@@ -19,6 +19,15 @@
 	var/click_cooldown_override = 0				//Override this to make your gun have a faster fire rate, in tenths of a second. 4 is the default gun cooldown.
 	var/harmful = TRUE //pacifism check for boolet, set to FALSE if bullet is non-lethal
 
+	/// What type of muzzle flash effect will be shown. If null then no effect and flash of light will be shown
+	var/muzzle_flash_effect = /obj/effect/temp_visual/target_angled/muzzle_flash
+	/// What color the flash has. If null then the flash won't cause lighting
+	var/muzzle_flash_color = LIGHT_COLOR_TUNGSTEN
+	/// What range the muzzle flash has
+	var/muzzle_flash_range = MUZZLE_FLASH_RANGE_WEAK
+	/// How strong the flash is
+	var/muzzle_flash_strength = MUZZLE_FLASH_STRENGTH_WEAK
+
 /obj/item/ammo_casing/New()
 	..()
 	if(projectile_type)