Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External snapshot file #38

Open
CedricGuillemet opened this issue Nov 14, 2023 · 1 comment
Open

External snapshot file #38

CedricGuillemet opened this issue Nov 14, 2023 · 1 comment

Comments

@CedricGuillemet
Copy link

CedricGuillemet commented Nov 14, 2023 •
edited
Loading

Latest packages have snapshot bin as external files.
Do envision to release a package with snapshots as non-external data ?

As I'm reading more carefully env.sh, I'm seeing that jit is disabled for non-external data:

v8-android-buildscripts/scripts/env.sh

Line 55 in fe84827

NO_JIT="true"

Is it possible to have JIT and non-external data?
@CedricGuillemet CedricGuillemet mentioned this issue Nov 14, 2023
Closed
@CedricGuillemet
Copy link
Author

I've forked the repo and built v8 without external data + JIT. with 1.1000.4 tag. Everything went right. Is it possible to add a published package without the need of external data @Kudo ?

@Kudo Kudo mentioned this issue Jan 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CedricGuillemet