Bug report + feature request #5
Labels
Comments
|
The first bug is fixed. I haven't ever seen the second bug. The third bug is easy to fix; I was going to change it but forgot. |
|
I just fixed the third bug. |
|
I just fixed a crash on exit which was caused by #1. The screen buffer shifts to the right when its address isn't divisible by 8, causing nPDF to crash when it tries to delete the buffer. |
|
Hm, can you tell me how that happened, Ndless SDK ver, Ndless version and OS version? |
|
When the address was not divisible by 8, the old code was trying to free an address which had never been allocated because of my code. |
|
Yeah, this kind of nasty bug was also present in early versions of the Zehn loaders. Tricky to find and reproduce. But the pointer returned by malloc (and thus new) MUST BE divisible by 8, so the bug must not have happened at all. |
|
critor was right, it's not always 8 bit-aligned See @matrefeytontias's comment in #1. |
Merged
I was trying to reproduce this today but I couldn't. Do you have any PDF's for which this happens? |
|
I'm having a problem where i cannot change pages .. I can zoom in and out, but looks like my pdf only has 1 page, at least when i click 3 to go to the next page nothing happens . Any idea on what could be the problem ? |
|
@EduardoPoco, could you try with the latest version? You can download it from http://ti-pla.net/a139503. Sorry for the delay. |
|
No problem, a friend of mine helped me to solve the problem. I think i saw on the instructions that to change page was on button 3, but it was on + sign. The program works great, thank you for the reply anyway and letting me know about the new release. |
|
OK, good to hear :) |
Legimet
added a commit
that referenced
this issue
Aug 19, 2018
4a7822d6 Fix VS project file. d6656ccf Update CHANGES and bump version. 2c70c339 Update Android.mk for recent build changes. 5cccad8f Remove needless #defines in load-jpx.c 2df3e5da Update jbig2dec submodule. 4f457ebb Update MuJS submodule to version 1.0.3. 35508e36 Fix CMap parsing bug when handling unicode surrogate pair ranges. 4ed1b852 Rework how we handle DynaLab tricky fonts in freetype. a6a17f72 Fix output paths in VS2005 project files. f873a4c4 Update examples. a3d3a4c0 For mutool create the encoding is not actually required. e7cc5e1d Set pointers to NULL so they can be safely dropped. 50dc275b Fix store multi-threading problem. 699c85ae jni: Expose interfaces for setting gamma and inverting pixmaps. b8c30529 Fix silly typo in pdf_load_compressed_inline_image. f4879a5c epub: Cope with empty (zero units tall) chapters. d09de342 Set CXX to C++ compiler when cross compiling. ef3cfb2a Don't implicitly drop in fz_open_* chained filters. d9f0fdfe Fix error message in tar archive code. fec19cec Fix error cleanup in pdf_load_font. 73867ca9 Android: Scavenge on Bitmap.lockPixels() failure. b8dd6744 Android: Avoid crashes if we fail to lock a Bitmap. b7895f15 Fix VS2008 build. 90defd07 Fix bug 696910 in a different way. 3dccb410 Use PDF object creation convenience functions. d92590ee Use pdf_add_new_dict family of functions. e0c05000 Add pdf_add_new_dict family of functions. 6d433a57 Use pdf_dict_put_dict family of functions. 8d6283fd Add pdf_dict_put_dict family of functions. fcba4e1a Add pkcs7 helper library to win32 viewer and mujstest tool. 6614c98b Add more version number #defines. e9111cc9 html: Build box model for tables. 4987023b html: Keep 'b' instead of 'h' in boxes. f11c41bd Add fz_output encoding filters. 71982219 Fall back to PDF document handler if no handler is found. dd0badd7 Check in script used to create encoding tables. 81c77a6b Clean up windows ifdefs. 5521ff9f Auto-size HTML layout if layout page height is 0. 5d9d99d2 Add phony target to java makefile so it properly rebuilds the native lib. 21e0da7e Load most annotations, even if they are missing appearances. f3b0e437 Fix 699085: Use at most 16 bytes from MD5 digests. 188d61ef Rearrange user password authentication code. bedb98a8 Fix 699130: Handle missing arguments in directives in mutool create. e681d134 Fix leak of form object when updating text appearance. 9b8c5380 Update to latest jbig2dec. be498ab7 Fix 699026: Create missing font resource. c0d8ee91 Update mutool create documentation with new font creation directives. 4b66d577 Simplify PDF font creation code. 1cd2046b Add simple fonts with 8-bit greek and cyrillic encodings. 2612c20b Add simple CJK font creation. 5a2b234c Add simple functions to create the built-in fonts by name. 596ff234 Use convenience function in pdf_set_annot_contents. 37451d06 Add simpler annotation line ending style accessors. f449fe60 Add annotation quadding accessor. e26a2c26 Add annotation opacity accessor. df788749 Only use BS/W for border width. 187bef3f Don't extract text from annotations by default. eea38800 Don't throw when fz_is_directory is called on a non-existent path. 64540ab1 Fix java build. 7e8807ea Update to latest jbig2dec. 40b2901b jni: Fix expression conflating booleans and bitfields. 3cc27abc Fix 699087: Get scissor from stack after new entry pushed. ace9e690 Fix 699086: Handle freetype not returning glyph advance. c273fe1b Do not warn if there are no JBIG2 globals. a3527d28 PDF stream filtering; fix pattern/xobject resource handling. 461b8154 Bug 699110: Fix Antialiased renderer to look at correct scale factor. b925766e Bug 699109: Fix overwrites with COP renderer. 3afca2bb Bug 698963: Fix dash rendering. c6acebf7 Bug 699106: Correct progress figures when using display_list. cc83451b Ensure we pass AA options to draw device and set text_bits appropriately. a7aac942 jni: Fix reference counting when creating PDF annotations. e9349d8f jni: Temporary fix to make sure annot AP field is updated. 4839427a Distinguish between simple and CID font resources in cache. 4614c747 Fix 699081: Missing coordinate transformation when copying text. 17d4efed Fix 699076: Scoping bug in png_write_band. 9f8e0724 Remove pdf_xobject wrapper struct. 8ebca3d5 Use fz_point for pdf_set_annot_ink_list and vertices too. ce03adbf Improve line ending style accessors. 51d84cb3 Add annotation QuadPoints creation functions. 4e490cbc Add annotation Line access functions. 4dfced06 Add annotation Vertices creation functions. f4441c3c Add annotation InkList creation functions. 185707aa Get border width from BS/W if Border is missing. 8eb35690 Return correct default icon names for optional annotation property. 5dc38275 Don't set a (useless) rectangle when creating annotations. 24fed963 Fix fz_expand_rect in presence of empty rectangles. 501b6c31 Add fz_expand_irect function. ee6e92b7 Add fz_translate_rect helper function. bcfee39b Add convenience functions to create point/rect/matrix. 6f199ed4 svg: Fix circle/ellipse drawing. 02885163 Fix bug in pdfshow (confusion between indirect/resolved streams). e5720af1 Remove typedef in favor of explicit enum keyword. 3af0e2db Fix bug in pdf_annot_icon_name. a8c34d21 Print newline at end of pdf_debug_obj. 58c07a42 jni: Add the ability to supply extra C flags to Android libmupdf builds. c3da8016 Don't use constants larger than will fit in a signed int in enum. b04a5e3d Use text encoding for pdf_choice_widget options and values. c2ff52c4 Use proper encoding for pdf_field_value and update_field_value. e4900061 Accept NULL in fz_drop_output. 22d0a3d5 Recognize Adobe illustrator files as PDF format. dd76e145 Include a font's style in its name. 02584b4f Remember to end knockout group when drawing image. b2e7d38e Bug 698890: Remember to end groups when showing images. f51836b9 Bug 698901: Drop pixmaps/knockout group upon error when ending group. 5b8ce880 Avoid revisiting the same page tree node repeatedly. 36cfeaf9 Add JNI and JS bindings to layer device calls. 60aa2d2f Add fz_begin_layer/fz_end_layer. 4e928c68 mutool extract: Don't save raw CMYK jpegs when the -r flag is enabled. 7085ddc1 Use indirect references when pre-loading image resources. 7570d162 Bug 699018: Null terminate buffer in fz_snprintf() even if too short. 9d34a795 jbig2: Improve error message. 21106086 jbig2 globals are streams, this implies indirect references. af27c82b Bug 698998: Avoid recursion when opening jbig2 image streams. f597f8dc Expose detailed PDF permissions. e09f6950 Don't pollute global namespace with __printflike. d84a2578 Clear search highlight when opening a new search, or hitting escape. e0ccccb4 Fix changed annotations not marked as dirty b0df4dfd Bug 698996: Disallow "" as owner password unless user password also "". 1c760a9d jni: Remove unnecessary close callback in seekable stream interface. 5cbf45b2 Add 'null' output device so we can remove NULL checks in hot functions. 4e30159a Add FZ_DEBUG_HTML option to EPUB parser. 01751d3d Add flag to Makethird to silence warnings when building freetype. 39a83e8f Fix 698991: The pdf_is_stream call is too generous. b59ff4e3 Fix 698918: Use encryption when doing initial object formatting to count the length. fb59e97f Fix silly mistake in fz_output buffering. 84087db5 Update Windows build to properly handle pkcs7 reorganisation d6bfd350 Fix uninitialised variable warning in fz_peek_byte a6cbde55 Workaround for Android: include limits.h where SIZE_MAX is used. f95c4e9c Include limits.h where INT_MAX/INT_MIN/PATH_MAX/UINT_MAX are used. dca5cca4 Bug 698986: Remember to fz_var() variable dropped in fz_catch(). 86b50343 Bug 698989: Throw upon unsupported bpc when unpacking image. 90421d4c Bug 698990: Start new run of font width only if not at end. 86224567 Bug 698988: Handle out of range predictors in filter. ed4a82d3 Remove redundant call to fz_rethrow(). beeb48ca Make sure to drop colorspace upon exception drawing contents. 71b26472 Free fz_output cache buffer when dropping fz_output. 86368172 Remove duplicated help string from mudraw. 4dcc6aff Bug 698891: Keep colorspace for luminosity transparency group. 8ec561d1 Signature support: add a null pdf_check_signature function e0b3451e Signature support: code-style and typo fixes 8bbe483b Signature support: fix windows build for the openssl-present case 0b04079f Signature support: decouple mupdf from the pkcs7 implementation 9b6b7ac9 Signature support: break out function for obtaining hash bytes 0312fb0e Signature support: simplify pkcs7 api by the removal of byte ranges. 8ac8d47f Generalise the null filter to handle more than a single range. 37e3d2aa Signature support: separate pkcs7 specifics into a separate file. 1ebb2db0 Signature support: use an enum to report errors. 7c94151a Signature support: separate the checkin of trust and digest. b105ae53 Cast data buffer to silence compiler warning. 4ccc9cdc Drop JPEG/J2K/JPEG-XR/PNG/TIFF colorspaces even upon exception. aa188d02 Do not allow out of range object numbers inside object stream. 2b0303c5 Skip objects inside object streams whose object ids are out of range. f472af04 Remove redundant seek in stream. ff6e1e16 Use 64-bit offsets when repairing PDF objects. 3e30fbb7 Bug 698908: Resize object use and renumbering lists after repair. b03def13 Bug 698830: Avoid recursion when loading object streams objects. 26527eef Bug 698830: Don't drop unkept stream if running out of error stack. ab98356f java: Don't overwrite LD_LIBRARY_PATH in 'run' target in java makefile. 87e2b6e2 Add pdf_debug_obj function to quickly print objects from gdb command line. 99b07a5b Return error token if strings are unterminated. 03dee17a Return PDF_TOK_ERROR when encountering isolated '>' and ')' characters. 43e6a76f Use convenience pdf dictionary/array creation functions. e4b3a9d4 Add convenience functions to set dict/array values by primitives. e0573b69 Add 'make tofu' target to build stripped mupdf with no unicode resources. 5d1e60c1 Rename confusing fz_stream close callback to drop. b4a4aaed Fix 698878: Mouse wheel scrolling. 8a3257b0 Fix 698886: Don't try to load non-stream XObjects. de39f005 Don't load an xobject before the stream is final when creating new forms. 58043713 Don't use signed int for parsing binary string into integer. dfcdcad5 Add buffering to fz_output. fbe951f0 Reduce size of pool allocator blocks to minimize waste. ebe3f450 Update mupdf_native.h header. 5e411a99 Bug 698916: Indirect object numbers must be in range. a71e7c85 Bug 698908: Plug PDF object leaks when decimating pages in pdfposter. 148329c6 If drawing to one file per page in mudraw, don't use append mode. 79963199 Bug 698942: Don't complain about external URLs being unknown. 5f90cd61 jni: Add Java interfaces to fz_stream and fz_output types. 4aced209 Put sanitize flags in separate flags variable. 4889fe51 Make sure to drop color converter when painting shades, even upon error. 8fdad62d Bug 698904: Drop pixmap only once upon error when painting shades. 83d4dae4 Bug 698904: Upon error both free color converter and clear its pointer. f5973004 Bug 698883: Reset cmap splay tree pointer, handling resized tree. 093fc3b0 Assert node range conditions when checking cmap splay trees. 71ceebcf Bug 698888: Keep one-to-many state when splitting nodes in cmap splay trees. 7f82c015 docs: Mention use of an incompatible fork of lcms2. 813144d3 Allow oversize allocations in pool allocator. 2bc74c66 Fix 698872: Do not trust ICC profile unconditionally in PNG files. 321ee2df Fix github issue #5: wrong return type from vec_dot in stext-device.c a55835a7 Fix failure of non-incremental document saving. 3e86abff Take on memory leak fix in lcms2. 791d24b2 Fix cut and paste bug in filter code. d9bc8c6f Bug 698885: When parsing PDF version, make sure to initialize buffer. 22339500 Bug 698889: Handle unterminated PDF arrays gracefully. 11ee2bcf cbz: Do not ask for page file name/extension unnecessarily. 90863862 Improve signature check failure reporting 31397fa8 Fix potential infinite loop when verifying signatures 660d5b95 Perform signature verification via fz_stream bcce8e5d Perform document signing via fz_stream and fz_output 457873fb Add fz_output_as_stream 37189046 Fix reading of pfx files 7b00d13e Further changes to signature support related to changes in openssl 55cf6715 Update use of openssl for signature support, from 1.0.1e to 1.1.0g 79aca97f Update LCMS2.art with latest LCMS2 changes. 80b59185 Fix 698865: Warn when failing to load embedded ICC profile in PNG images. a54a6ff9 Bug 698857: Delete local reference after use. a926254b Use C comments instead of C++ comments. 3df11d8c Only do lock checking if using custom locks. a2a4ad9d Handle pixmaps without alpha in fz_tint_pixmap. bec33a47 Add colorspace type enum and use it instead of hardcoded checks on N. b70eb93f Don't allow reading from a 'dead' fz_stream. 0d7359fb Handle exceptions in fz_peek_byte the same way as in fz_read_byte. b840e169 Refactor and fix hash lookups when decoding image subarea tiles. 11c1803c Fix initializer syntax for VS2005. fd0bf575 Enable saving of encrypted PDF files. 25593f4f Fix "being able to search for redacted text" bug. 1202a24a Update 'mutool run' man page. 36ae5236 Bug 698836: Fix build with FZ_ENABLE_JPX=0. 2d5b4683 Add portable pseudo-random number generator based on the lrand48 family. a292539c Fix thread debugging code to always use ms_clock() 7b7e16a5 Update LCMS2 with optimisations from GS. 7307a7f2 Bug 698827: Correct reference counting when creating pixmap from pixmap. 5e84be24 Bug 698826: Plug leak of font names when parsing appearance string. 321ba1de Bug 698825: Do not drop borrowed colorspaces. 308c8d8e Initialize generation numbers when saving a new pdf. 2a161103 Validate that /Size in trailer is in range. b1ee9743 PDF object numbers need not be int64_t, int is sufficient. 72f9012f Define constant INT64_MAX where int64_t is declared. bd41b371 Move xref section recursion check, simplifying code. e4b5ee99 Rephrase messages, clarify variable names and remove unused code. 22985917 Never write negative xref offsets when saving to PDF. 55c3f68d Bugs 698804/698810/698811: Keep PDF object numbers below limit. c7a47008 Update MuJS submodule. 8daf5b3b Add 'tar.xz' to "make tarball" script. a66a5541 Don't pass -Wdeclaration-after-statement to C++ compiler. eacd0701 Parse XML using pool allocator. fa9cd085 Fix 698785: Catch malformed numbers in PDF lexical scanner. 5722ebc5 Fix 698787: avoid using "system()" to copy files. 2d6e0ebc Put extra apps in separate (non-default) makefile build target. 634d64e4 Add 'clean' option to pdfclean to clean (but not sanitize) content streams. c4d4d6cf gl: Tell glut to return from main loop when the window closes. git-subtree-dir: mupdf git-subtree-split: 4a7822d6750ecb6e0b63f4357738dc20ecaa58f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I'm testing nPDF with huge files (eBooks with several hundreds of pages).
Bug report - I've noticed :
Feature request :
Regards.
The text was updated successfully, but these errors were encountered: