Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with pluggy 1.4 #32

Open
Midnighter opened this issue Aug 4, 2024 · 2 comments
Open

Compatibility issue with pluggy 1.4 #32

Midnighter opened this issue Aug 4, 2024 · 2 comments

Comments

@Midnighter
Copy link

pytest-raises has been my trusted companion for many years now. Since pluggy 1.4, however, old-style hook wrappers cause test failures.

pluggy.PluggyTeardownRaisedWarning: A plugin raised an exception during an old-style hookwrapper teardown.

There is a discussion at pytest-dev/pytest#11858, for example, that mentions potential approaches.

@AetherUnbound
Copy link
Contributor

@svenevs @Lemmons I'm seeing this as well - I can take a stab at it to try and find a solution, but I wanted to check in. Are you two around for possibly deploying a new version as well? There's some maintenance that might be beneficial for the project (since the last release was in 2020). Happy to pitch in on that if you'd like 🙂

@svenevs
Copy link
Collaborator

svenevs commented Aug 23, 2024

Hey team, I'm happy to try and look into this on Sunday. Generally this plugin is intended to be feature complete / low maintenance, but it does appear it's time for a facelift.

I haven't had time to dig into what's going on, but from a brief skim of the linked issue it does seem like we've got a viable path forward. @AetherUnbound if you have time to get a prototype working I can definitely review and make sure the packaging requirements are updated etc.

Thank you @Midnighter for the detailed report and link to the discussion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants