Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to Qt 6 #297

Open
fbriere opened this issue Aug 31, 2022 · 0 comments
Open

Porting to Qt 6 #297

fbriere opened this issue Aug 31, 2022 · 0 comments
Assignees
Labels

Comments

@fbriere
Copy link
Collaborator

fbriere commented Aug 31, 2022

Now that Qt 6 has been released for over a year and is included in most distributions (including Ubuntu 22.04 LTS), porting Twinkle to it seems like a nice little project. 😄

@fbriere fbriere added the GUI label Aug 31, 2022
@fbriere fbriere self-assigned this Aug 31, 2022
fbriere added a commit to fbriere/twinkle that referenced this issue Sep 1, 2022
`QRegularExpression` was introduced in Qt 5.0 as a successor to
`QRegExp`, and while it is still supported under Qt6 (via
`Core5Compat`), the corresponding `QRegExpValidator` is not.  Hence,
migrating will be required before being able to port to Qt 6 (LubosD#297).

While `QRegularExpressionValidator` is not always a drop-in replacement
for `QRegExp` (see the documentation¹ for details), in our case, it is.
Our use doesn't run into any of the situations listed, while our only
instance of `exactMatch()` uses a pattern that is already anchored.

 ¹ https://doc.qt.io/qt-5/qregularexpression.html#notes-for-qregexp-users
fbriere added a commit to fbriere/twinkle that referenced this issue Sep 1, 2022
`QRegularExpression` was introduced in Qt 5.0 as a successor to
`QRegExp`, and while it is still supported under Qt 6 (via
`Core5Compat`), the corresponding `QRegExpValidator` is not.  Hence,
migrating will be required before being able to port to Qt 6 (LubosD#297).

While `QRegularExpression` is not always a drop-in replacement for
`QRegExp` (see the documentation¹ for details), in our case, it is.  Our
use doesn't run into any of the situations listed in the documentation,
while our only instance of `exactMatch()` uses a pattern that is already
anchored.

 ¹ https://doc.qt.io/qt-5/qregularexpression.html#notes-for-qregexp-users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant