Skip to content

Commit cd34070

Browse files
Marc Dionnetorvalds
Marc Dionne
authored andcommitted
afs: Fix possible assert with callbacks from yfs servers
Servers sending callback breaks to the YFS_CM_SERVICE service may send up to YFSCBMAX (1024) fids in a single RPC. Anything over AFSCBMAX (50) will cause the assert in afs_break_callbacks to trigger. Remove the assert, as the count has already been checked against the appropriate max values in afs_deliver_cb_callback and afs_deliver_yfs_cb_callback. Fixes: 35dbfba ("afs: Implement the YFS cache manager service") Signed-off-by: Marc Dionne <[email protected]> Signed-off-by: David Howells <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent cc07903 commit cd34070

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

fs/afs/callback.c

-1
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,6 @@ void afs_break_callbacks(struct afs_server *server, size_t count,
312312
_enter("%p,%zu,", server, count);
313313

314314
ASSERT(server != NULL);
315-
ASSERTCMP(count, <=, AFSCBMAX);
316315

317316
/* TODO: Sort the callback break list by volume ID */
318317

0 commit comments

Comments
 (0)