Add transform_marker to arrows and default to true in 3D
#4871
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffreyer
changed the title
tranform_marker to arrows and default to true in 3Dtransform_marker to arrows and default to true in 3D
Benchmark ResultsSHA: 375c74fe25e405ef8bca7518e76c8e45afe4c001 Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.
|
SimonDanisch
approved these changes
Mar 17, 2025
SimonDanisch
approved these changes
Mar 17, 2025
|
I'm wondering if we should revert this at the level of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4870
Reverts a change in defaults caused by #4606
Arrows assumes the scattered meshes to transform just like a normal mesh. I.e. to get the correct length all the vertices should effectively go through the full transformation pipeline. This is not the case with
transform_marker = false, as that excludes model.Type of change
Checklist