Fix method doc signatures for multiline required parameters (googleapis#374)

* Fix method doc signatures for multiline required parameters.

Existing doc generator failed to recognize parameters as required when parameter descriptions
extended over more than one line. Besides presenting incorrect information, resulting
inconsistencies broke checks for automated sample generation.

* Regen docs

Author: tcoffee-google

describe.py

@@ -200,15 +200,23 @@ def method_params(doc):
       args = doclines[begin+1:]
 
     parameters = []
+    pname = None
+    desc = ''
+    def add_param(pname, desc):
+      if pname is None:
+        return
+      if '(required)' not in desc:
+        pname = pname + '=None'
+      parameters.append(pname)
     for line in args:
       m = re.search('^\s+([a-zA-Z0-9_]+): (.*)', line)
       if m is None:
+        desc += line
         continue
+      add_param(pname, desc)
       pname = m.group(1)
       desc = m.group(2)
-      if '(required)' not in desc:
-        pname = pname + '=None'
-      parameters.append(pname)
+    add_param(pname, desc)
     parameters = ', '.join(parameters)
   else:
     parameters = ''

docs/dyn/adexchangebuyer2_v2beta1.accounts.clients.html

@@ -85,7 +85,7 @@ <h2>Instance Methods</h2>
 <p class="firstline">Returns the users Resource.</p>
 
 <p class="toc_element">
-  <code><a href="#create">create(accountId=None, body, x__xgafv=None)</a></code></p>
+  <code><a href="#create">create(accountId, body, x__xgafv=None)</a></code></p>
 <p class="firstline">Creates a new client buyer.</p>
 <p class="toc_element">
   <code><a href="#get">get(accountId, clientAccountId, x__xgafv=None)</a></code></p>
@@ -97,11 +97,11 @@ <h2>Instance Methods</h2>
   <code><a href="#list_next">list_next(previous_request, previous_response)</a></code></p>
 <p class="firstline">Retrieves the next page of results.</p>
 <p class="toc_element">
-  <code><a href="#update">update(accountId=None, clientAccountId, body, x__xgafv=None)</a></code></p>
+  <code><a href="#update">update(accountId, clientAccountId, body, x__xgafv=None)</a></code></p>
 <p class="firstline">Updates an existing client buyer.</p>
 <h3>Method Details</h3>
 <div class="method">
-    <code class="details" id="create">create(accountId=None, body, x__xgafv=None)</code>
+    <code class="details" id="create">create(accountId, body, x__xgafv=None)</code>
   <pre>Creates a new client buyer.
 
 Args:
@@ -342,7 +342,7 @@ <h3>Method Details</h3>
 </div>
 
 <div class="method">
-    <code class="details" id="update">update(accountId=None, clientAccountId, body, x__xgafv=None)</code>
+    <code class="details" id="update">update(accountId, clientAccountId, body, x__xgafv=None)</code>
   <pre>Updates an existing client buyer.
 
 Args:

docs/dyn/adexchangebuyer2_v2beta1.accounts.clients.invitations.html

@@ -75,20 +75,20 @@
 <h1><a href="adexchangebuyer2_v2beta1.html">Ad Exchange Buyer API II</a> . <a href="adexchangebuyer2_v2beta1.accounts.html">accounts</a> . <a href="adexchangebuyer2_v2beta1.accounts.clients.html">clients</a> . <a href="adexchangebuyer2_v2beta1.accounts.clients.invitations.html">invitations</a></h1>
 <h2>Instance Methods</h2>
 <p class="toc_element">
-  <code><a href="#create">create(accountId, clientAccountId=None, body, x__xgafv=None)</a></code></p>
+  <code><a href="#create">create(accountId, clientAccountId, body, x__xgafv=None)</a></code></p>
 <p class="firstline">Creates and sends out an email invitation to access</p>
 <p class="toc_element">
-  <code><a href="#get">get(accountId, clientAccountId=None, invitationId, x__xgafv=None)</a></code></p>
+  <code><a href="#get">get(accountId, clientAccountId, invitationId, x__xgafv=None)</a></code></p>
 <p class="firstline">Retrieves an existing client user invitation.</p>
 <p class="toc_element">
-  <code><a href="#list">list(accountId, clientAccountId=None, pageSize=None, pageToken=None, x__xgafv=None)</a></code></p>
+  <code><a href="#list">list(accountId, clientAccountId, pageSize=None, pageToken=None, x__xgafv=None)</a></code></p>
 <p class="firstline">Lists all the client users invitations for a client</p>
 <p class="toc_element">
   <code><a href="#list_next">list_next(previous_request, previous_response)</a></code></p>
 <p class="firstline">Retrieves the next page of results.</p>
 <h3>Method Details</h3>
 <div class="method">
-    <code class="details" id="create">create(accountId, clientAccountId=None, body, x__xgafv=None)</code>
+    <code class="details" id="create">create(accountId, clientAccountId, body, x__xgafv=None)</code>
   <pre>Creates and sends out an email invitation to access
 an Ad Exchange client buyer account.
 
@@ -105,11 +105,11 @@ <h3>Method Details</h3>
     "clientAccountId": "A String", # Numerical account ID of the client buyer
         # that the invited user is associated with.
         # The value of this field is ignored in create operations.
+    "invitationId": "A String", # The unique numerical ID of the invitation that is sent to the user.
+        # The value of this field is ignored in create operations.
     "email": "A String", # The email address to which the invitation is sent. Email
         # addresses should be unique among all client users under each sponsor
         # buyer.
-    "invitationId": "A String", # The unique numerical ID of the invitation that is sent to the user.
-        # The value of this field is ignored in create operations.
   }
 
   x__xgafv: string, V1 error format.
@@ -126,16 +126,16 @@ <h3>Method Details</h3>
       "clientAccountId": "A String", # Numerical account ID of the client buyer
           # that the invited user is associated with.
           # The value of this field is ignored in create operations.
+      "invitationId": "A String", # The unique numerical ID of the invitation that is sent to the user.
+          # The value of this field is ignored in create operations.
       "email": "A String", # The email address to which the invitation is sent. Email
           # addresses should be unique among all client users under each sponsor
           # buyer.
-      "invitationId": "A String", # The unique numerical ID of the invitation that is sent to the user.
-          # The value of this field is ignored in create operations.
     }</pre>
 </div>
 
 <div class="method">
-    <code class="details" id="get">get(accountId, clientAccountId=None, invitationId, x__xgafv=None)</code>
+    <code class="details" id="get">get(accountId, clientAccountId, invitationId, x__xgafv=None)</code>
   <pre>Retrieves an existing client user invitation.
 
 Args:
@@ -157,16 +157,16 @@ <h3>Method Details</h3>
       "clientAccountId": "A String", # Numerical account ID of the client buyer
           # that the invited user is associated with.
           # The value of this field is ignored in create operations.
+      "invitationId": "A String", # The unique numerical ID of the invitation that is sent to the user.
+          # The value of this field is ignored in create operations.
       "email": "A String", # The email address to which the invitation is sent. Email
           # addresses should be unique among all client users under each sponsor
           # buyer.
-      "invitationId": "A String", # The unique numerical ID of the invitation that is sent to the user.
-          # The value of this field is ignored in create operations.
     }</pre>
 </div>
 
 <div class="method">
-    <code class="details" id="list">list(accountId, clientAccountId=None, pageSize=None, pageToken=None, x__xgafv=None)</code>
+    <code class="details" id="list">list(accountId, clientAccountId, pageSize=None, pageToken=None, x__xgafv=None)</code>
   <pre>Lists all the client users invitations for a client
 with a given account ID.
 
@@ -209,11 +209,11 @@ <h3>Method Details</h3>
           "clientAccountId": "A String", # Numerical account ID of the client buyer
               # that the invited user is associated with.
               # The value of this field is ignored in create operations.
+          "invitationId": "A String", # The unique numerical ID of the invitation that is sent to the user.
+              # The value of this field is ignored in create operations.
           "email": "A String", # The email address to which the invitation is sent. Email
               # addresses should be unique among all client users under each sponsor
               # buyer.
-          "invitationId": "A String", # The unique numerical ID of the invitation that is sent to the user.
-              # The value of this field is ignored in create operations.
         },
     ],
   }</pre>

docs/dyn/adexchangebuyer2_v2beta1.accounts.clients.users.html

@@ -75,20 +75,20 @@
 <h1><a href="adexchangebuyer2_v2beta1.html">Ad Exchange Buyer API II</a> . <a href="adexchangebuyer2_v2beta1.accounts.html">accounts</a> . <a href="adexchangebuyer2_v2beta1.accounts.clients.html">clients</a> . <a href="adexchangebuyer2_v2beta1.accounts.clients.users.html">users</a></h1>
 <h2>Instance Methods</h2>
 <p class="toc_element">
-  <code><a href="#get">get(accountId, clientAccountId=None, userId, x__xgafv=None)</a></code></p>
+  <code><a href="#get">get(accountId, clientAccountId, userId, x__xgafv=None)</a></code></p>
 <p class="firstline">Retrieves an existing client user.</p>
 <p class="toc_element">
-  <code><a href="#list">list(accountId=None, clientAccountId, pageSize=None, pageToken=None, x__xgafv=None)</a></code></p>
+  <code><a href="#list">list(accountId, clientAccountId, pageSize=None, pageToken=None, x__xgafv=None)</a></code></p>
 <p class="firstline">Lists all the known client users for a specified</p>
 <p class="toc_element">
   <code><a href="#list_next">list_next(previous_request, previous_response)</a></code></p>
 <p class="firstline">Retrieves the next page of results.</p>
 <p class="toc_element">
-  <code><a href="#update">update(accountId, clientAccountId=None, userId, body, x__xgafv=None)</a></code></p>
+  <code><a href="#update">update(accountId, clientAccountId, userId, body, x__xgafv=None)</a></code></p>
 <p class="firstline">Updates an existing client user.</p>
 <h3>Method Details</h3>
 <div class="method">
-    <code class="details" id="get">get(accountId, clientAccountId=None, userId, x__xgafv=None)</code>
+    <code class="details" id="get">get(accountId, clientAccountId, userId, x__xgafv=None)</code>
   <pre>Retrieves an existing client user.
 
 Args:
@@ -130,7 +130,7 @@ <h3>Method Details</h3>
 </div>
 
 <div class="method">
-    <code class="details" id="list">list(accountId=None, clientAccountId, pageSize=None, pageToken=None, x__xgafv=None)</code>
+    <code class="details" id="list">list(accountId, clientAccountId, pageSize=None, pageToken=None, x__xgafv=None)</code>
   <pre>Lists all the known client users for a specified
 sponsor buyer account ID.
 
@@ -208,7 +208,7 @@ <h3>Method Details</h3>
 </div>
 
 <div class="method">
-    <code class="details" id="update">update(accountId, clientAccountId=None, userId, body, x__xgafv=None)</code>
+    <code class="details" id="update">update(accountId, clientAccountId, userId, body, x__xgafv=None)</code>
   <pre>Updates an existing client user.
 Only the user status can be changed on update.
 

docs/dyn/adexchangebuyer2_v2beta1.accounts.creatives.dealAssociations.html

@@ -78,7 +78,7 @@ <h2>Instance Methods</h2>
   <code><a href="#add">add(accountId, creativeId, body, x__xgafv=None)</a></code></p>
 <p class="firstline">Associate an existing deal with a creative.</p>
 <p class="toc_element">
-  <code><a href="#list">list(accountId=None, creativeId=None, pageSize=None, pageToken=None, x__xgafv=None, query=None)</a></code></p>
+  <code><a href="#list">list(accountId, creativeId, pageSize=None, pageToken=None, x__xgafv=None, query=None)</a></code></p>
 <p class="firstline">List all creative-deal associations.</p>
 <p class="toc_element">
   <code><a href="#list_next">list_next(previous_request, previous_response)</a></code></p>
@@ -126,7 +126,7 @@ <h3>Method Details</h3>
 </div>
 
 <div class="method">
-    <code class="details" id="list">list(accountId=None, creativeId=None, pageSize=None, pageToken=None, x__xgafv=None, query=None)</code>
+    <code class="details" id="list">list(accountId, creativeId, pageSize=None, pageToken=None, x__xgafv=None, query=None)</code>
   <pre>List all creative-deal associations.
 
 Args: