-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vue 2 support #78
Comments
@messenjer are you still going to look into this? |
Hi, @MaxLeiter The issue is related to Vue sfc (single file component) compilation and Vue-demi I don't think this is clearly explained on the vue-demi repository and in the articles about it. But, analyzing how the sfc vue compilation works, I don't really see how to say when compiling the sfc that it should mention vue-demi instead of vue. An issue related : vueuse/vue-demi#139 When you look at the vue-use project which uses vue-demi everywhere they don't use sfc files for their components anywhere. Look at the new useSortable component: https://github.com/vueuse/vueuse/blob/main/packages/integrations/useSortable/component.ts The .vue file should be rewritten as a .ts file with definecomponent. For the moment I won't have the opportunity to look at this, because I'm changing job, I don't have a laptop anymore, but I start my new job on monday, hopefully I'll still be working on vue and there will still be vue2 to vue3 migrations. If I find the opportunity I'll do it. Regards Mathieu |
no worries @messenjer, thanks for looking into it and your contibution. Best of luck with the new job! |
Introduced in #70 that closed #69
The text was updated successfully, but these errors were encountered: