-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meros suggests LAN IPs as peers to foreign clients. #167
Comments
We set the Peer.server flag in Live/Sync ManagerObj. We can unify these checks under Network, where we have access to the TransportAddress. Using the TransportAddress, we can call isLoopback/isLinkLocal and not set Peer.sever accordingly. |
Actually, we can't unify this checks unless we move the handshake receiving around as well. There's a reason I didn't do that already. New plan is to pass the TransportAddress. |
The fact Peers test now fails, as described in 7f3c23c, proves this is working. It's marked as untested until:
|
This isn't a huge bug. The foreign clients will attempt the IP, fail, and move on. That said, it isn't proper.
The text was updated successfully, but these errors were encountered: