Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain codebase sections need investigating. #174

Open
kayabaNerve opened this issue Jun 4, 2020 · 2 comments
Open

Certain codebase sections need investigating. #174

kayabaNerve opened this issue Jun 4, 2020 · 2 comments
Labels
bug Something isn't working untested This issue, or its fix, needs testing to verify its accuracy

Comments

@kayabaNerve
Copy link
Member

As #173 noted, annotations have been added to ConsensusObj and Transactions. Some of these annotations seem to describe pointless code, yet others point at underlying problems which need to be fixed.

@kayabaNerve kayabaNerve added bug Something isn't working untested This issue, or its fix, needs testing to verify its accuracy labels Jun 4, 2020
@kayabaNerve kayabaNerve added this to the DT5.0 milestone Jun 5, 2020
@kayabaNerve
Copy link
Member Author

kayabaNerve commented Jun 6, 2020

ConsensusObj has this comment, which is above the block I was mostly concerned about:

    #[
    We can't mention a Transaction unless we its parent is already mentioned.
    That said, we should be to also mention its parent in the same Block.
    We also won't have a child TX without its parents.
    This code should be pointless, and actually detrimental to the speed of the network.
    In fact, the entire included variable should be.
    -- Kayaba
    ]#

This is valid code, made in response to #88. That said, it may be a bit overzealous. Once I make sure it isn't, I'll cross this off.

kayabaNerve added a commit that referenced this issue Jun 6, 2020
@kayabaNerve
Copy link
Member Author

I did try to clean up the setStatus function. As TransactionStatus is a ref, that makes it even more redundant. That said, the existing setStatus works, even if it's ugly/complicated.

That solely leaves marking Transactions as beaten, relevant to pruning Transactions, and making sure deleting statuses is done properly.

@kayabaNerve kayabaNerve removed this from the Developer Testnet 5.0 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untested This issue, or its fix, needs testing to verify its accuracy
Development

No branches or pull requests

1 participant