You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As #173 noted, annotations have been added to ConsensusObj and Transactions. Some of these annotations seem to describe pointless code, yet others point at underlying problems which need to be fixed.
The text was updated successfully, but these errors were encountered:
ConsensusObj has this comment, which is above the block I was mostly concerned about:
#[
We can't mention a Transaction unless we its parent is already mentioned.
That said, we should be to also mention its parent in the same Block.
We also won't have a child TX without its parents.
This code should be pointless, and actually detrimental to the speed of the network.
In fact, the entire included variable should be.
-- Kayaba
]#
This is valid code, made in response to #88. That said, it may be a bit overzealous. Once I make sure it isn't, I'll cross this off.
I did try to clean up the setStatus function. As TransactionStatus is a ref, that makes it even more redundant. That said, the existing setStatus works, even if it's ugly/complicated.
That solely leaves marking Transactions as beaten, relevant to pruning Transactions, and making sure deleting statuses is done properly.
As #173 noted, annotations have been added to ConsensusObj and Transactions. Some of these annotations seem to describe pointless code, yet others point at underlying problems which need to be fixed.
The text was updated successfully, but these errors were encountered: