Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketcher needs collision tests. #216

Open
kayabaNerve opened this issue Jul 17, 2020 · 0 comments
Open

Sketcher needs collision tests. #216

kayabaNerve opened this issue Jul 17, 2020 · 0 comments
Labels
untested This issue, or its fix, needs testing to verify its accuracy

Comments

@kayabaNerve
Copy link
Member

If Meros has a collision internally, it should generate a new salt for the template. If Meros has a collision internally, yet is syncing, it should fail to handle the sketch yet still successfully sync the Block, as long as it doesn't have a collision.

Meros should also be to handle being sent Blocks with a collision. Due to the set theory used for sketches, it's impossible to include a sketch with the same item twice. That said, it is still possible to create a sketchCheck merkle with the same values twice, and therefore a Block Header.

@kayabaNerve kayabaNerve added the untested This issue, or its fix, needs testing to verify its accuracy label Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untested This issue, or its fix, needs testing to verify its accuracy
Development

No branches or pull requests

1 participant