Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Docker image #11

Open
ahmedihabb2 opened this issue Jul 18, 2022 · 2 comments
Open

[Feature] Docker image #11

ahmedihabb2 opened this issue Jul 18, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@ahmedihabb2
Copy link
Collaborator

Create docker image for easily usage without need to install node and npm

@Mostafa-wael Mostafa-wael added the good first issue Good for newcomers label Jul 18, 2022
@ahmednreldin
Copy link

ahmednreldin commented Jul 18, 2022

do you wanna docker image build app via npx i.e. npx @quran-cli/q-cli

or build it locally i.e. install node, npm, typescript then run node src/index.js

despite that both will require node, npm installation and typescript for the second
and both method will require installation of mpv

@Mostafa-wael
Copy link
Owner

We need a Docker image with mpv and node installed.
You can run it in the way that suits you the best.
You can either copy the files while building the image, or just run using npx.
So, the file would look something like this:
Mpv image - > install node - > run using npx.
If something is not clear enough, don't hesitate to ask!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants