Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectator Fix not working #1434

Open
5 tasks done
tooobiiii opened this issue Feb 16, 2025 · 52 comments
Open
5 tasks done

Spectator Fix not working #1434

tooobiiii opened this issue Feb 16, 2025 · 52 comments
Labels
Resolution: Added / Fixed Feature added / issue was fixed Type: Bug Plugin is not working as described on the wiki
Milestone

Comments

@tooobiiii
Copy link

Server version

Velocity-CTD 3.4.0

TAB version

5.0.7

Plugin list

Image

Image

Describe the bug

Players see spectators when switching
Important: If player joined and someone is already gm3 it works!!!

Expected behavior

Spectators should be hidden from Players without the permission

Steps to reproduce

Install TAB on velocity
Enable Spectator Fix
Have Someone without the perm join a backend
Get yourself in gm3
Important: If player joined and someone is already gm3 it works!!!

Additional info

No response

Checklist

  • I am running latest version of the plugin
  • I have read the wiki to make sure it's not an issue with configuration
  • I ticked all of the boxes without actually reading them
  • I have read the Compatibility wiki page and am not trying to run the plugin on an unsupported server version / platform
  • I am willing to cooperate to get this issue resolved faster, including providing any additional information requested or testing new builds
@tooobiiii tooobiiii added the Type: Bug Plugin is not working as described on the wiki label Feb 16, 2025
@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Image
Are you sure tablist uuids match properly? You can identify this by setting different tabprefix and tagprefix and confirming it's indeed tabprefix appearing in tablist.

@tooobiiii
Copy link
Author

i ticked this bc i trolled...

@tooobiiii
Copy link
Author

i will check one sec

@tooobiiii
Copy link
Author

seems like you are correct.

Image
Changing this made no changes in tab

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Try toggling use-online-uuid-in-tablist.

@tooobiiii
Copy link
Author

still nothing changed

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Is your proxy in online mode?

@tooobiiii
Copy link
Author

sure is

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Is your paper.yml configured to enable velocity support and forwarding and all of those weird complicated settings?

@tooobiiii
Copy link
Author

should be ill double check

@tooobiiii
Copy link
Author

Image

@tooobiiii
Copy link
Author

i mean it always worked but eventually it broke
Do you thing velocity ctd could be the issue?

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Find out by switching to normal velocity.

@tooobiiii
Copy link
Author

theres lots of players online atm i can check when theres fewer

@tooobiiii
Copy link
Author

ill just setup a test network one sec

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Try reproducing the issue on a test network on localhost.

@tooobiiii
Copy link
Author

i started setting it up any ptero any specific reason for local?

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

No, that was just an idea. People usually say they don't have any test servers available when I tell them to try it there.

@tooobiiii
Copy link
Author

just asking, any issue with enfore-secure-profile set to false? or in velocity anything related to chat reporting?

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

That shouldn't be related.

@tooobiiii
Copy link
Author

well now luckperms placeholders wont resolve :D

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

That has nothing to do with this issue and isn't required to reproduce it.

@tooobiiii
Copy link
Author

okay then im done

@tooobiiii
Copy link
Author

Image
Tab is still showing the placeholder
on velocity now

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

After all this time I managed to configure velocity so that I can actually connect to it, I have
use-online-uuid-in-tablist: true
and it works
Image

@tooobiiii
Copy link
Author

no wait, it takes the tagprefix to tablist instead of tabpreifx

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Yes? Isn't that what you described already?

@tooobiiii
Copy link
Author

i changed tab instead of tag to indentify a change

@tooobiiii
Copy link
Author

...

@tooobiiii
Copy link
Author

so yea changing the prefix in groups.yml does indeed change the tablist prefix on the main server

@tooobiiii
Copy link
Author

i thought tabprefix was the one to change in order to see that but i was wrong

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

I use:

proxies:
  bungee-cord:
    online-mode: true
  proxy-protocol: false
  velocity:
    enabled: true
    online-mode: true
    secret: <secret>

in paper-global.yml and

online-mode = true
force-key-authentication = true
player-info-forwarding-mode = "modern"

in velocity.toml.

Do you have the same settings?

@tooobiiii
Copy link
Author

i can confirm yes

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

And the TAB setting on the same value? And regardless of whether it's true or false tabprefix still doesn't appear? Is the feature enabled?

@tooobiiii
Copy link
Author

Well the tabprefix is not the problem. Tab prefix does appear and work properly the only thing i have issues with is the hide specators to users thing

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Yes, and the most likely cause is tablist uuids not matching between expected and actual, and tablist formatting is an easy way to find out. Can you show output of /btab debug <player>?

@tooobiiii
Copy link
Author

Image

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Image
you trolling?

@tooobiiii
Copy link
Author

sorry if i missunderstood anything but the spectator fix setting is indeed enabled

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

I meant tablist formatting. Obviously we cannot confirm if tablist formatting works if the feature is disabled. Enable it back and see if it actually works. If it does, check if spectator fix is still broken on that test server (don't forget you'll still see yourself as spectator).

@tooobiiii
Copy link
Author

now gives me this in debug need one sec booting my other client

Image
i have 6.0.1 bridge installed

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Not being connected is a very good reason why spectator fix may not be working.

@tooobiiii
Copy link
Author

well soime fucked up configuration of mine oin the test server the main network is connected via bridge

@tooobiiii
Copy link
Author

ill just enable it there and see

@tooobiiii
Copy link
Author

Image
i can see myself in tab as a spec (on other client)

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

what does /btab parse <spectator player> %gamemode% return?

@tooobiiii
Copy link
Author

Image

@tooobiiii
Copy link
Author

Were you able to reproduce the issue or is some configuration on my side fucked up

@tooobiiii
Copy link
Author

And when a player is already in gm3 and another joins it works but it always fails when switching while both are online

@NEZNAMY NEZNAMY added the Resolution: Added / Fixed Feature added / issue was fixed label Feb 16, 2025
@NEZNAMY NEZNAMY added this to the 5.0.8 milestone Feb 16, 2025
@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Were you able to reproduce the issue

yes

@tooobiiii
Copy link
Author

Could you send a velocity build so i can use the version already if possible

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 16, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Added / Fixed Feature added / issue was fixed Type: Bug Plugin is not working as described on the wiki
Projects
None yet
Development

No branches or pull requests

2 participants