Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadBalancerContext.noteResponse never called, and LoadBalancerContext.noteRequestCompletion doesn't include the actual request #448

Open
chairbender opened this issue Apr 3, 2020 · 0 comments

Comments

@chairbender
Copy link

https://github.com/Netflix/ribbon/search?q=noteResponse&unscoped_q=noteResponse

This method is implemented and overridable but seems it never actually gets called.

I was hoping to use this so I could log the request URL and actual service instance that a request was sent to. I couldn't find a non-hacky way to do this other than sticking that info into a response header in noteRequestCompletion. LoadBalancerContext.noteRequestCompletion DOES get called (in LoadBalancerCommand, for example), but it doesn't include the ClientHttpRequest in the params so I can't see what URL this response is for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant