Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write full list of tbl_pd methods #5

Open
NickCH-K opened this issue Jul 15, 2019 · 2 comments
Open

Write full list of tbl_pd methods #5

NickCH-K opened this issue Jul 15, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@NickCH-K
Copy link
Owner

NickCH-K commented Jul 15, 2019

I've started writing tbl_pd methods for dplyr verbs so that pdeclare status is preserved when using non-pmdplyr functions, and pdeclare status is dropped if the .i or .t variables are removed. The goal is to eventually have the full list of dplyr verbs covered, as well as as many other methods as possible. So the to-do is:

  1. Write tbl_pd methods for all dplyr verbs
  2. Figure out which non-dplyr functions should also have methods
  3. Write methods for all of those too.
@NickCH-K NickCH-K added the enhancement New feature or request label Jul 15, 2019
@NickCH-K NickCH-K changed the title Write full list of tbl_df methods Write full list of tbl_pd methods Jul 16, 2019
@NickCH-K
Copy link
Owner Author

83e2a40 fills in the major dplyr verbs, other than the scoped variants. Next up are the scoped variants, and rewriting what's there so it doesn't use :::

@NickCH-K
Copy link
Owner Author

108e3c6 includes all scoped variants and all major dplyr verbs except bind_rows which for some reason refuses to call bind_rows.tbl_pd (perhaps because it allows a list first argument?), also fixes other minor issues.

@philip-khor philip-khor mentioned this issue Aug 13, 2019
25 tasks
@NickCH-K NickCH-K added this to the 0.4.0 Checklist milestone Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant