Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request: standardnotes 3.181.23 → 3.191.4 #293270

Closed
baalajimaestro opened this issue Mar 4, 2024 · 2 comments · Fixed by #365265
Closed

Update request: standardnotes 3.181.23 → 3.191.4 #293270

baalajimaestro opened this issue Mar 4, 2024 · 2 comments · Fixed by #365265
Labels
9.needs: package (update) This needs a package to be updated

Comments

@baalajimaestro
Copy link

  • Package name: standardnotes

  • Latest released version: 3.191.4

  • Current version on the unstable channel: 3.181.23

  • Current version on the stable/release channel: 3.181.23

  • [* ] Checked the nixpkgs pull requests

Notify maintainers

@M-Gregoire
@chuangzhu
@squalus


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@baalajimaestro baalajimaestro added the 9.needs: package (update) This needs a package to be updated label Mar 4, 2024
@higherorderfunctor
Copy link

higherorderfunctor commented Mar 31, 2024

This overlay works for me. Just overriding the version and src breaks without the phase changes due to the spaces in the path during updateAutotoolsGnuConfigScriptsPhase. It appears to split the path here:

for f in $(find . -type f -name "$script"); do

Also need to pin electron_27 to match the package version set here: https://github.com/standardnotes/app/blob/4b19076f9b549a00c98eca8e1c35ee0d62e05155/packages/desktop/package.json#L46

Edit: my current overlay for standard notes tracking upstream repo using nvfetcher: https://github.com/higherorderfunctor/nixos-config/blob/dotfiles/overlays/standardnotes-overlay.nix

@higherorderfunctor
Copy link

higherorderfunctor commented Jun 15, 2024

You now have to allow electron 27 to be used since it went EOL.

I reported it upstream: standardnotes/forum#3626

      import nixpkgs {
        inherit system;
        overlays = import ./overlays {inherit inputs lib;};
        config = {
          allowUnfree = true;
          permittedInsecurePackages = [
            "electron-27.3.11" # standard notes
          ];
        };
      });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.needs: package (update) This needs a package to be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants