Build failure: wesnoth after staging-next 2024-12-04 #361878

[spiage]

Steps To Reproduce

Steps to reproduce the behavior:

1. build wesnoth at nixpkgs/master

Build log

error: builder for '/nix/store/gr3548r1724wgc972k14bhyv0gwd9yi2-wesnoth-1.18.2.drv' failed with exit code 2;
       last 25 log lines:
       >   933 |         const std::vector<std::string>& paths = filesystem::get_binary_paths("images");
       >       |                                         ^~~~~
       > /build/source/src/picture.cpp:933:77: note: the temporary was destroyed at the end of the full expression 'filesystem::get_binary_paths(std::__cxx11::basic_string<char>(((const char*)"images"), std::allocator<char>()))'
       >   933 |         const std::vector<std::string>& paths = filesystem::get_binary_paths("images");
       >       |                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
       > [ 97%] Building CXX object src/CMakeFiles/wesnoth-client.dir/widgets/textbox.cpp.o
       > [ 97%] Building CXX object src/CMakeFiles/wesnoth-client.dir/widgets/widget.cpp.o
       > [ 97%] Building CXX object src/CMakeFiles/wesnoth-client.dir/wml_exception.cpp.o
       > [ 98%] Building CXX object src/CMakeFiles/wesnoth-client.dir/desktop/dbus_features.cpp.o
       > [ 98%] Building CXX object src/CMakeFiles/wesnoth-client.dir/sdl/exception.cpp.o
       > [ 98%] Building CXX object src/CMakeFiles/wesnoth-client.dir/sdl/rect.cpp.o
       > [ 98%] Building CXX object src/CMakeFiles/wesnoth-client.dir/sdl/surface.cpp.o
       > [ 98%] Building CXX object src/CMakeFiles/wesnoth-client.dir/sdl/utils.cpp.o
       > [ 98%] Building CXX object src/CMakeFiles/wesnoth-client.dir/sdl/window.cpp.o
       > [ 99%] Building CXX object src/CMakeFiles/wesnoth-client.dir/xBRZ/xbrz.cpp.o
       > /build/source/src/theme.cpp: In constructor 'theme::menu::menu(std::size_t, std::size_t, const config&)':
       > /build/source/src/theme.cpp:523:21: warning: possibly dangling reference to a temporary []
       >   523 |         const auto& cmd = hotkey::get_hotkey_command(items_[0]["id"]);
       >       |                     ^~~
       > /build/source/src/theme.cpp:523:53: note: the temporary was destroyed at the end of the full expression 'hotkey::get_hotkey_command(config_attribute_value::operator std::string() const())'
       >   523 |         const auto& cmd = hotkey::get_hotkey_command(items_[0]["id"]);
       >       |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
       > [ 99%] Linking CXX static library libwesnoth-client.a
       > [ 99%] Built target wesnoth-client
       > make: *** [Makefile:156: all] Error 2
       For full logs, run 'nix log /nix/store/gr3548r1724wgc972k14bhyv0gwd9yi2-wesnoth-1.18.2.drv'.

Additional context

Metadata

Notify maintainers

@abbradar

---

Note for maintainers: Please tag this issue in your PR.

---

Add a 👍 reaction to issues you find important.

[spiage]

@abbradar
Hi! Could it be useful?
00a8abb