Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tab tooltip is obstructing the adjacent tab #19

Open
kreba opened this issue Aug 16, 2017 · 2 comments · Fixed by OddMorning/legacy.vertical-tabs-plus#1
Open

The tab tooltip is obstructing the adjacent tab #19

kreba opened this issue Aug 16, 2017 · 2 comments · Fixed by OddMorning/legacy.vertical-tabs-plus#1

Comments

@kreba
Copy link

kreba commented Aug 16, 2017

Hi tiger4th,
thanks for this plugin! I'm new to Atom and seeing that this is available brightened my day (^o^)/

One thing I keep tripping over is that sometimes I can't click on a tab because another tab's tooltip is obstructing it. This occurs when I am slowly moving the mouse pointer over and down the tabs. I do this quite often when looking for a specific tab to open.

screenshot

My suggestion would be to display the tooltip to the right of the tab instead of below it. Or to the left when the tabs are on the right side. That way it does not hover over an adjacent tab but instead over the editor.

I imagine this to be a trivial css fix – but then again, I don't know anything about development for Atom, yet (^_^)'

What do you think?

Cheers, Raffael

@kreba
Copy link
Author

kreba commented Aug 16, 2017

Update: clicking on an obstructed tab is actually possible. But I wouldn't see what I am clicking.
I might want to activate or just close that tab.
When I close multiple tabs I don't need anymore, and am moving the mouse up and down the tabs list, a lot of nervous flickering goes on with the tooltips. I don't think vertical-tabs should fix the flickering, but if you can make the tooltips not obstruct other tabs in the process, that would already be a huge improvement!

OddMorning added a commit to OddMorning/legacy.vertical-tabs-plus that referenced this issue Nov 14, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* New settings appearance.
* Added an experimental setting that fixes [tooltips placement](tiger4th#19).
@OddMorning
Copy link

I'm not the author but I made some research and figured out the following things. In short: it's not possible for CSS. It's possible for JS though but it requires a lot of tricky code that still will never work smooth.

It's not possible for CSS since Atom creates a global tooltip that's placed in the root DOM element and has nothing related to tabs. It's controlled with API inside of the tabs package (built-in features are packages as well). What about JS, that tabs package stores an internal variable called hasBeenMousedOver in every tab. It's false by default, and when it's false, atom renders a tooltip and sets it to true. I know how to render tooltips myself but I can do nothing to that variable, it's impossible to set it to true manually (packages are isolated from each other), I ended up my attempts by having two tooltips displaying at the same time: mine (on the left/right side) and default (below) ones.
It's also possible to just catch existing tooltips and change their position but sometimes they display instantly (without any delay) so custom code just can't keep up with tooltips and they display below a tab. That happens once per new "fast cursor entered" tab but that's still can't be considered as a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants