Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndis miniport characteristics missing #15

Open
sstjohn opened this issue Jan 6, 2016 · 1 comment
Open

ndis miniport characteristics missing #15

sstjohn opened this issue Jan 6, 2016 · 1 comment

Comments

@sstjohn
Copy link

sstjohn commented Jan 6, 2016

Commit 2ab5e88 introduced a 'g' before the definition of PRODUCT_TAP_WIN_CHARACTERISTICS in version.m4, which doesn't match the regex in buildtap.py's BuildTAPWindows.parse_version_m4 method. Consequently, the generated INF describes the characteristics of the device as "" (the empty string), which erroneously becomes a 0 in the registry, rather than the correct value of 0x81 (NCF_VIRTUAL | NCF_HAS_UI).

@mattock
Copy link
Member

mattock commented Jan 8, 2016

Hi,

We're in the process of getting an EV code-signing certificate for signing the tap-windows6 driver. Once that is taken care of, we can fix this bug and rebuild. If we did publish a new driver now, it will not (afaik) work on Windows 10, because of Microsoft's new driver signing policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants