Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a #60

Closed
hell001 opened this issue Aug 16, 2024 · 1 comment
Closed

a #60

hell001 opened this issue Aug 16, 2024 · 1 comment

Comments

@hell001
Copy link

hell001 commented Aug 16, 2024

a

@OrfiDev
Copy link
Member

OrfiDev commented Aug 16, 2024

  1. isn't that for cover images? Anyway, compression can be "disabled" by using PNG instead of JPG on supported cover modules, since that does lossless compression, whereas I'm pretty sure you physically can't not lose any data with JPG. Though I have no clue why you'd want to have such a massive file be embedded in the FLAC/whatever file itself, it can cause issues and that's what the external cover system is for.
  2. ignore it, the advanced login system was supposed to add a feature from RedSea that was missing in OrpheusDL, but was never completed
  3. yes, it's automatic based on the conversions you list out. Undesirable conversions are lossy-to-lossy and even worse, lossy-to-lossless.
  4. it's an ffmpeg flag https://stackoverflow.com/a/44839083
  5. when you use a separate cover module to the one you're downloading with for better or even original quality (or even with the Apple Music module, downloading the actual original file), it compares it to the cover from the original module, and if the difference found by the algorithm is greater than the threshold, the candidate cover is rejected.
  6. see # 3 above.
  7. in hindsight, a better name for it is probably skip existing file check, I never even thought about it being misleading
  8. during artist downloads, in albums by other artists, this will skip all the songs not by the artist you are downloading
  9. there are no public extensions iirc, but they're kinda like modules for modules lol

@hell001 hell001 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2025
@hell001 hell001 changed the title Config options missing documentation a Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants