Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXP coupons purchased from cash shop stack #252

Open
wejrox opened this issue Jul 19, 2024 · 1 comment
Open

EXP coupons purchased from cash shop stack #252

wejrox opened this issue Jul 19, 2024 · 1 comment

Comments

@wejrox
Copy link

wejrox commented Jul 19, 2024

Describe the bug

In this server, you can buy 2x multiple times and they all stack.
I'm not certain, but I think this applies exponentially too, so rates x 2 x 2 instead of rates x 4.

To Reproduce
Steps to reproduce the behavior:

  1. Type @rates
  2. Note the rate
  3. Buy x2 exp coupon
  4. Repeat 1-2
  5. Buy x2 exp
  6. Repeat 1-2

Observe the behaviour.

Expected behavior

Exp rate is multiplied by 2.

In vanilla, if you buy three 2x exp coupons, you don't get 8x exp, only 2x.

Screenshots
If applicable, add screenshots to help explain your problem.

@wejrox
Copy link
Author

wejrox commented Jul 22, 2024

Turns out I had the config flag USE_STACK_COUPON_RATES enabled.
However, it seems like if it's disabled only one EXP coupon can apply at once, which is not correct with vanilla. There was more complicated logic to allow some event coupons and some other usables to stack with the cash shop coupon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant