Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

宠物捡取会停止攻击 #76

Open
qq985252784 opened this issue Jun 6, 2022 · 6 comments
Open

宠物捡取会停止攻击 #76

qq985252784 opened this issue Jun 6, 2022 · 6 comments

Comments

@qq985252784
Copy link

宠物捡取会停止攻击会禁止放技能,希望大神告诉一下方法。

@P0nk
Copy link
Owner

P0nk commented Aug 2, 2022

Can you translate to english please?

@ghost
Copy link

ghost commented Aug 20, 2022

I think he is saying that pet's picking up items interferes with using skills/attacking, ie the player has to wait for the pet to finish looting before they can attack.

@StickStack
Copy link

Locally experimenting with changes to PetLootHandler.java down to Character.pickupItem yielded these observations:

  1. Not registering the pet loot opcode removes the responsiveness issues (even with client sends the op at 10 times in 1.4 seconds)
  2. Turning PetLootHandler into a do nothing handler only minimizes the issue
  3. Hardcoding inventory space check to return false so only mesos are ever picked up improved responsiveness
  4. Refactoring the item pickup code to an async queue design that immediately responds with PacketCreator.enableActions() helped a bit

It looks like various code choices are exacerbating the issue but hard to say how much of this is an inherent issue surfaced from higher drop rates. I could also be looking in the wrong place and the MapItem/Map/Player locking code could be the issue.

Other reference to the same issue mentioned (different source but I don't know the history of these repositories):

@Arnuh
Copy link

Arnuh commented Nov 14, 2022

public static Packet updatePlayerStats(List<Pair<Stat, Integer>> stats, boolean enableActions, Character chr) {
When a pet is picking up items, the enableActions bool should be false for all updatePlayerStats sent in drop pickup. It has to be true for player pickup.

Turning PetLootHandler into a do nothing handler only minimizes the issue

This has to be false, or it's not doing enough of "nothing"

@ChisBread
Copy link

This is a limitation of the client. Keywords: super tubi

@ColaMint
Copy link

ColaMint commented Aug 2, 2023

use HxD to replace these bytes in hendi's client, then you get super tubi!

0x00085C01: 0x90
0x00085C02: 0x90

0x00085C08: 0x90
0x00085C09: 0x90

0x00085C21: 0x90
0x00085C22: 0x90

0x00085C32: 0x90
0x00085C33: 0x90

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants