Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that v3.8 features require #version 3.8 #420

Open
c-lipka opened this issue Jun 17, 2021 · 0 comments
Open

Verify that v3.8 features require #version 3.8 #420

c-lipka opened this issue Jun 17, 2021 · 0 comments
Labels
cleanup miscellaneous housekeeping
Milestone

Comments

@c-lipka
Copy link
Contributor

c-lipka commented Jun 17, 2021

Unless #version 3.8 is specified, any v3.8 features should either be disabled (if automatic) or trigger a warning (if requiring extra syntax), so that the user doesn't accidently mark a scene as v3.7 compatible that actually requires v3.8 to render as intended.

It needs to be verified that this is true for all v3.8 features.

It also should be douible-checked that the equivalent is true for all v3.7 features unless #version 3.7 or above is specified.

@c-lipka c-lipka added the cleanup miscellaneous housekeeping label Jun 17, 2021
@c-lipka c-lipka added this to the v3.8.0-rc1 milestone Jun 17, 2021
c-lipka added a commit that referenced this issue Jul 11, 2021
- Addresses issue #420
- POV-Ray will now warn when using v3.7 or v3.8 features without matching `#version` directive.
- For consistency, POV-Ray will no longer throw an error whenever encountering anything macro-related in v3.0 scenes, and instead just warn when encountering `#macro` in such scenes.
- Modified internal tracking of scene language version to use a dedicated class instead of an `int`.
- Added a framework to print certain warnings only once.
trevorsandy pushed a commit to trevorsandy/povray that referenced this issue Jul 18, 2021
- Addresses issue POV-Ray#420
- POV-Ray will now warn when using v3.7 or v3.8 features without matching `#version` directive.
- For consistency, POV-Ray will no longer throw an error whenever encountering anything macro-related in v3.0 scenes, and instead just warn when encountering `#macro` in such scenes.
- Modified internal tracking of scene language version to use a dedicated class instead of an `int`.
- Added a framework to print certain warnings only once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup miscellaneous housekeeping
Projects
None yet
Development

No branches or pull requests

1 participant