Skip to content

Commit f1fa20a

Browse files
Fix UseWebpackDevMiddleware with no options
1 parent 980054b commit f1fa20a

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/Microsoft.AspNet.SpaServices/Webpack/WebpackDevMiddleware.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,11 @@ public static class WebpackDevMiddleware
1818

1919
public static void UseWebpackDevMiddleware(this IApplicationBuilder appBuilder, WebpackDevMiddlewareOptions options = null) {
2020
// Validate options
21-
if (options != null) {
22-
if (options.ReactHotModuleReplacement && !options.HotModuleReplacement) {
23-
throw new ArgumentException("To enable ReactHotModuleReplacement, you must also enable HotModuleReplacement.");
24-
}
21+
if (options == null) {
22+
options = new WebpackDevMiddlewareOptions();
23+
}
24+
if (options.ReactHotModuleReplacement && !options.HotModuleReplacement) {
25+
throw new ArgumentException("To enable ReactHotModuleReplacement, you must also enable HotModuleReplacement.");
2526
}
2627

2728
// Unlike other consumers of NodeServices, WebpackDevMiddleware dosen't share Node instances, nor does it
@@ -43,7 +44,7 @@ public static void UseWebpackDevMiddleware(this IApplicationBuilder appBuilder,
4344
// Tell Node to start the server hosting webpack-dev-middleware
4445
var devServerOptions = new {
4546
webpackConfigPath = Path.Combine(appEnv.ApplicationBasePath, options.ConfigFile ?? DefaultConfigFile),
46-
suppliedOptions = options ?? new WebpackDevMiddlewareOptions()
47+
suppliedOptions = options
4748
};
4849
var devServerInfo = nodeServices.InvokeExport<WebpackDevServerInfo>(nodeScript.FileName, "createWebpackDevServer", JsonConvert.SerializeObject(devServerOptions)).Result;
4950

0 commit comments

Comments
 (0)