Skip to content

Commit

Permalink
Say SQLite BLOB protos are ideally temporary
Browse files Browse the repository at this point in the history
We ideally want a schema that's pure SQL and doesn't embed
protos. However some protos we don't have time to translate
quite yet. So we put a BLOB as the last field so it can be
migrated later.

Please note there might end up being some things highly
specific to TensorFlow and/or Google that end up here. In
those cases we might consider keeping the proto blobs
permanently, if they're difficult to express in SQL.

PiperOrigin-RevId: 182313847
  • Loading branch information
jart authored and tensorflower-gardener committed Jan 18, 2018
1 parent 2b6bb5c commit 4d9bef1
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tensorflow/contrib/tensorboard/db/schema.cc
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,8 @@ Status SetupTensorboardSqliteDb(Sqlite* db) {
// inserted_time: Float UNIX timestamp with µs precision. This is
// always the wall time of when the row was inserted into the
// DB. It may be used as a hint for an archival job.
// node_def: Contains tf.GraphDef proto. All fields will be cleared
// except those not expressed in SQL.
// graph_def: Contains the tf.GraphDef proto parts leftover which
// haven't been defined in SQL yet.
s.Update(Run(db, R"sql(
CREATE TABLE IF NOT EXISTS Graphs (
rowid INTEGER PRIMARY KEY,
Expand Down Expand Up @@ -375,8 +375,8 @@ Status SetupTensorboardSqliteDb(Sqlite* db) {
// node_def.name proto field must not be cleared.
// op: Copied from tf.NodeDef proto.
// device: Copied from tf.NodeDef proto.
// node_def: Contains tf.NodeDef proto. All fields will be cleared
// except those not expressed in SQL.
// node_def: Contains the tf.NodeDef proto parts leftover which
// haven't been defined in SQL yet.
//
// TODO(jart): Make separate tables for op and device strings.
s.Update(Run(db, R"sql(
Expand Down

0 comments on commit 4d9bef1

Please sign in to comment.