Skip to content

Commit 4d9bef1

Browse files
jarttensorflower-gardener
authored andcommitted
Say SQLite BLOB protos are ideally temporary
We ideally want a schema that's pure SQL and doesn't embed protos. However some protos we don't have time to translate quite yet. So we put a BLOB as the last field so it can be migrated later. Please note there might end up being some things highly specific to TensorFlow and/or Google that end up here. In those cases we might consider keeping the proto blobs permanently, if they're difficult to express in SQL. PiperOrigin-RevId: 182313847
1 parent 2b6bb5c commit 4d9bef1

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tensorflow/contrib/tensorboard/db/schema.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -339,8 +339,8 @@ Status SetupTensorboardSqliteDb(Sqlite* db) {
339339
// inserted_time: Float UNIX timestamp with µs precision. This is
340340
// always the wall time of when the row was inserted into the
341341
// DB. It may be used as a hint for an archival job.
342-
// node_def: Contains tf.GraphDef proto. All fields will be cleared
343-
// except those not expressed in SQL.
342+
// graph_def: Contains the tf.GraphDef proto parts leftover which
343+
// haven't been defined in SQL yet.
344344
s.Update(Run(db, R"sql(
345345
CREATE TABLE IF NOT EXISTS Graphs (
346346
rowid INTEGER PRIMARY KEY,
@@ -375,8 +375,8 @@ Status SetupTensorboardSqliteDb(Sqlite* db) {
375375
// node_def.name proto field must not be cleared.
376376
// op: Copied from tf.NodeDef proto.
377377
// device: Copied from tf.NodeDef proto.
378-
// node_def: Contains tf.NodeDef proto. All fields will be cleared
379-
// except those not expressed in SQL.
378+
// node_def: Contains the tf.NodeDef proto parts leftover which
379+
// haven't been defined in SQL yet.
380380
//
381381
// TODO(jart): Make separate tables for op and device strings.
382382
s.Update(Run(db, R"sql(

0 commit comments

Comments
 (0)