From 02038136cdbc7eacacb21825d6138b7dc875ac6d Mon Sep 17 00:00:00 2001 From: Kieran Date: Wed, 24 Sep 2025 14:54:34 +0100 Subject: [PATCH 1/3] Fix Implicitly marking parameter $maxItems as nullable is deprecated --- src/ArrayAssertsTrait.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ArrayAssertsTrait.php b/src/ArrayAssertsTrait.php index f4d0899..6f8c3c2 100644 --- a/src/ArrayAssertsTrait.php +++ b/src/ArrayAssertsTrait.php @@ -158,7 +158,7 @@ public static function arrayHasKeyWith($key, $constraint): ArrayHasKeyWith public static function assertSequentialArray( $array, int $minItems, - int $maxItems = null, + ?int $maxItems = null, $constraint = null, bool $ignoreKeys = false, string $message = '' @@ -185,7 +185,7 @@ public static function assertSequentialArray( */ public static function sequentialArray( int $minItems, - int $maxItems = null, + ?int $maxItems = null, $constraint = null, bool $ignoreKeys = false ): SequentialArray { From 542215aeb5984a5b1a9c6a568ace6d91193e3f27 Mon Sep 17 00:00:00 2001 From: Kieran Date: Wed, 24 Sep 2025 15:35:21 +0100 Subject: [PATCH 2/3] Change maxItems parameter to nullable integer --- src/Constraint/SequentialArray.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Constraint/SequentialArray.php b/src/Constraint/SequentialArray.php index 976b059..de721ec 100644 --- a/src/Constraint/SequentialArray.php +++ b/src/Constraint/SequentialArray.php @@ -77,7 +77,7 @@ class SequentialArray extends Constraint * * @throws InvalidArgumentException */ - public function __construct(int $minItems = 0, int $maxItems = null, $constraint = null, bool $ignoreKeys = false) + public function __construct(int $minItems = 0, ?int $maxItems = null, $constraint = null, bool $ignoreKeys = false) { if ($minItems < 0) { throw InvalidArgumentException::create(1, 'non-negative integer'); From 43614f17072c1fdb26d0a8745c0e2d84cdee8f2d Mon Sep 17 00:00:00 2001 From: Daniel Rudolf Date: Wed, 24 Sep 2025 17:45:29 +0200 Subject: [PATCH 3/3] Fix implicit nullable parameters deprecation in unit tests --- tests/TestCase.php | 2 +- tests/Unit/ArrayAssertsTraitTest.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/TestCase.php b/tests/TestCase.php index 7850694..3faecad 100644 --- a/tests/TestCase.php +++ b/tests/TestCase.php @@ -52,7 +52,7 @@ abstract class TestCase extends \PHPUnit\Framework\TestCase protected function mockConstraint( $constraint, array $invocationRules = [], - array $evaluateParameters = null + ?array $evaluateParameters = null ) { if (!($constraint instanceof Constraint)) { return $constraint; diff --git a/tests/Unit/ArrayAssertsTraitTest.php b/tests/Unit/ArrayAssertsTraitTest.php index d45cc6c..ff83d03 100644 --- a/tests/Unit/ArrayAssertsTraitTest.php +++ b/tests/Unit/ArrayAssertsTraitTest.php @@ -450,7 +450,7 @@ public function dataProviderArrayHasItemWithFail(): array private function mockConstraintInstance( string $className, array $constructorArguments = [], - array $evaluateArguments = null + ?array $evaluateArguments = null ): MockInterface { $instanceMock = Mockery::mock('overload:' . $className, Constraint::class);