Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests to confirm that expiring environment variables are still valid #2106

Open
5 tasks
anth-volk opened this issue Jan 17, 2025 · 0 comments · May be fixed by #2151
Open
5 tasks

Create tests to confirm that expiring environment variables are still valid #2106

anth-volk opened this issue Jan 17, 2025 · 0 comments · May be fixed by #2151
Assignees

Comments

@anth-volk
Copy link
Collaborator

anth-volk commented Jan 17, 2025

There are a few environment variables in use within the API that frequently expire, but we must run the entire test suite to know that they are expired, and then we typically receive arcane test errors when they do emerge. We should have a small suite of tests that runs before all others (this is critical) that ensures these are still valid. I'll update this issue down the road to list what they are and suggest a simple way of testing each, but I think it's around at most 3.

Overall, addressing this issue would require the following:

  • Write a simple test for each environment variable (will elaborate later)
  • Modify GitHub Actions push and pull_request scripts to run this before other tests
  • (Potentially) Modify Makefile to create command to run the relevant tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants