Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PolyMathOrg/PolyMath
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: PolyMathOrg/PolyMath
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release
Choose a head ref
  • 5 commits
  • 3 files changed
  • 4 contributors

Commits on Jan 25, 2020

  1. Release PolyMath v1.0.2 (#165)

    * [skip CI]
    
    * [skip CI]
    
    * [skip CI] typos
    
    * [skip CI]
    
    * Update SMark to 1.0.3
    
    * Update README.md
    
    * [Issue 152] Remove Magic From 'initialize' Methods (#153)
    
    * [issue-152] Improved code formatting.
    
    * [issue-152] Removed some reflection magic so that the code is easier to understand.
    
    * [issue-152] Improved code formatting.
    
    * Cleanup to load in PharoGs (#150)
    
    * Do not use an inst variable name as an argument
    
    * Don't use 'p' and 'q' as method temps
    
    They are defined as instance variables in the class. If they are not supposed to modify the instance variable, then they should have different names.
    
    * Don't begin a block with a dot
    
    GemStone isn't happy with empty statements.
    
    * Cleanup of Array constructors
    
    While legal syntax, GemStone has trouble parsing these.
    
    * Don't use instance var name as method argument
    
    * Add spacing to clarify when number ends
    
    GemStone doesn't like '11do:' as a number since 'd' is a legal exponent.
    
    * Spacing to clarify separation of statements
    
    * Fix typo with extra space.
    
    * [issue-154] Corrected the behaviour of findKey to return 'AllTheRest' when selector has no corresponding initialize message. (#155)
    
    * [issue-154] Corrected the behaviour of findKey, making it more testable in the subclass to mitigate risk.
    
    * [issue-154] Promoted the local variables in the test to state variable to remove duplication.
    
    * [issue-154] Extracted duplicate code to a custom assertion.
    
    * [skip CI]
    
    * [skip CI]
    
    * Create FUNDING.yml
    
    * Update FUNDING.yml
    
    * Remove curly braces, replaced with Arrays in most cases, should close #159 (#162)
    
    * Update dependencies to load from github, should close #160 (#161)
    
    * [Issue 154] Refactor PMAccuracy testDataTree method (#163)
    
    * [issue-154] Moved the test method to its own test case class so that we can break up the long test method and understand the message better.
    
    * [issue-154] Moved some test code to an intention-revealing test method & identified a possible smell.
    
    * [issue-154] Moved a block of code to its own intention-revealing test method.
    
    * [issue-154] Moved some test code to its own intention-revealing method.
    
    * [issue-154] Added a smell comment to help the next developer.
    
    * [issue-154] Added more smells to the smell comment.
    
    * [issue-154] Moved the test code to an intention-revealing test method, extracted the expected result to a role-revealing local variable.
    
    * [issue-154] Extracted test code to its own intention-revealing test method, with a comment identifying a coincidence between expected outcome and a default I discovered in the initialize method.
    
    * [issue-154] Added calls to the super class methods as required.
    
    * [issue-154] Put the call to the super class method in the right place.
    
    * [issue-154] Improved the name of the local variable. We still don't know the role it plays in the test yet so gave it a structural name.
    
    * [issue-154] Improved the name of a local variable.
    
    * [issue-154] Moved the test code to its own better named test method.
    
    * Update .travis.yml
    
    * Update appveyor.yml
    
    * Fix some of the red tests for Pharo 8 (#164)
    
    * Update appveyor.yml
    
    * Move from Pharo 7.0 to Pharo 8.0
    
    * Update README.md
    
    Co-authored-by: Hemal Varambhia <[email protected]>
    Co-authored-by: James Foster <[email protected]>
    Co-authored-by: Julian Maestri <[email protected]>
    4 people authored Jan 25, 2020
    Configuration menu
    Copy the full SHA
    95aebd1 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2021

  1. Fix conflicts

    SergeStinckwich committed May 23, 2021
    Configuration menu
    Copy the full SHA
    708b72a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #204 from PolyMathOrg/master

    Sync release with master
    SergeStinckwich authored May 23, 2021
    Configuration menu
    Copy the full SHA
    50ab9e0 View commit details
    Browse the repository at this point in the history
  3. Delete appveyor.yml

    SergeStinckwich authored May 23, 2021
    Configuration menu
    Copy the full SHA
    7ccf945 View commit details
    Browse the repository at this point in the history
  4. Delete .travis.yml

    SergeStinckwich authored May 23, 2021
    Configuration menu
    Copy the full SHA
    6387247 View commit details
    Browse the repository at this point in the history
Loading