Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: disable retry randomize flag #205

Closed
VisargD opened this issue Feb 13, 2024 · 0 comments · Fixed by #206
Closed

Fix: disable retry randomize flag #205

VisargD opened this issue Feb 13, 2024 · 0 comments · Fixed by #206
Assignees
Labels
bug Something isn't working

Comments

@VisargD
Copy link
Collaborator

VisargD commented Feb 13, 2024

Gateway uses async-retry with default settings internally to perform retries. The default settings of async retry also has randomize flag set to true. Due to this the timeouts between retries can have a random behaviour as they get multiplied randomly by a number between 1 and 2. So the retry timeouts follow a random pattern instead of following 1s, 2s, 4s, 8s and 16s pattern.

We should set randomize to false to avoid any random timeout behaviour for retries.

Docs for async-retry default settings: https://github.com/vercel/async-retry#readme

Image

@VisargD VisargD added the bug Something isn't working label Feb 13, 2024
@VisargD VisargD self-assigned this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant