false variable is assigned but never used recommendation (same as ticket #1354)

[zdenko-s]

False report about unused variable

Steps to reproduce

$modified = $false
$source | ForEach-Object {
   if ($_.LocalName -eq 'key') {
      $modified = $true
   }
}
return $modified

Another case:

$modified = $false
$source | ForEach-Object {
   if ($_.LocalName -eq 'key') {
      $modified = $true
   }
}
if($modified) {

}

Expected behavior

No warning

Actual behavior

Warning:
The variable 'modified' is assigned but never used.PSScriptAnalyzer(PSUseDeclaredVarsMoreThanAssignments)

Warning is present since long time ago
Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      7.5.1
PSEdition                      Core
GitCommitId                    7.5.1
OS                             Microsoft Windows 10.0.26100
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }
1.23.0

[OtterKring]

I have a very similar case. I am translating a array of objects to a hashtable:

$ADHash = Get-ADUser | Foreach-Object -Begin { $h = @{} } -Process { $h[$_.samaccountname] = $_ } -End { $h }

Warns about $h being assigned but never used. This warning is also present for many years.